Skip to content

Conversation

ipavlidakis
Copy link
Contributor

🧪 Manual Testing Notes

  • Freshly install the app
  • Have someone call you while the app isn't running and your screen is locked
  • When you join the call, permission popups should show up

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis self-assigned this Sep 1, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 1, 2025 14:20
@ipavlidakis ipavlidakis added the enhancement New feature or request label Sep 1, 2025
Copy link

github-actions bot commented Sep 1, 2025

Public Interface

 public final class PermissionStore: ObservableObject, @unchecked Sendable  
-   @Published public private var hasMicrophonePermission: Bool
+   @Published public private var canRequestMicrophonePermission: Bool
-   @Published public private var hasCameraPermission: Bool
+   @Published public private var hasMicrophonePermission: Bool
-   
+   @Published public private var canRequestCameraPermission: Bool
- 
+   @Published public private var hasCameraPermission: Bool
-   public func requestMicrophonePermission()async throws -> Bool
+   
-   public func requestCameraPermission()async throws -> Bool
+ 
-   public func requestPushNotificationPermission(with options: UNAuthorizationOptions)async throws -> Bool
+   public func requestMicrophonePermission()async throws -> Bool
+   public func requestCameraPermission()async throws -> Bool
+   public func requestPushNotificationPermission(with options: UNAuthorizationOptions)async throws -> Bool

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 1, 2025

SDK Size

title develop branch diff status
StreamVideo 8.51 MB 8.53 MB +17 KB 🟢
StreamVideoSwiftUI 2.36 MB 2.36 MB +1 KB 🟢
StreamVideoUIKit 2.48 MB 2.48 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

Copy link

sonarqubecloud bot commented Sep 1, 2025

@ipavlidakis ipavlidakis force-pushed the fix/permission-requests branch from ffa9609 to 382f14e Compare September 1, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants