Skip to content

Secret scan path fail on known matches #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liiight opened this issue May 15, 2025 · 0 comments
Open

Secret scan path fail on known matches #1097

liiight opened this issue May 15, 2025 · 0 comments
Labels
status:new This issue needs to be reviewed type:bug Something isn't working

Comments

@liiight
Copy link

liiight commented May 15, 2025

Environment

  • ggshield version: 1.39
  • Operating system (Linux, macOS, Windows): macOS
  • Operating system version: 15.4.1
  • Python version: 3.12

Describe the bug

Running ggshield secret scan path [PATH] where the path is a file with a known (ignored) match fails

Actual result:

❯ ggshield secret scan path src/detections/jsons/event_with_profile/f95088a9-4224-4f81-81e3-619d7b421b67.json
Scanning... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 1 / 1

Error: Scanning failed: {'scan_results': {0: {'policy_breaks': {0: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 1: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data
for required field.']}, 2: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 3: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 4:
{'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 5: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 6: {'detector_name': ['Missing data for
required field.'], 'detector_group_name': ['Missing data for required field.']}, 7: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 8: {'detector_name': ['Missing data for required field.'],
'detector_group_name': ['Missing data for required field.']}, 9: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 10: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data
for required field.']}, 11: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 12: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 13:
{'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 14: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 15: {'detector_name': ['Missing data for
required field.'], 'detector_group_name': ['Missing data for required field.']}, 16: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 17: {'detector_name': ['Missing data for required field.'],
'detector_group_name': ['Missing data for required field.']}, 18: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data for required field.']}, 19: {'detector_name': ['Missing data for required field.'], 'detector_group_name': ['Missing data
for required field.']}}}}}

Expected result:

Successful scan.

Running the exact same scan with v1.38 works:

❯ uvx --from ggshield==1.38 ggshield secret scan path src/detections/jsons/event_with_profile/f95088a9-4224-4f81-81e3-619d7b421b67.json
Installed 27 packages in 82ms
Scanning... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 1 / 1

> src/detections/jsons/event_with_profile/f95088a9-4224-4f81-81e3-619d7b421b67.json: 0 secrets detected
>
@liiight liiight added type:bug Something isn't working status:new This issue needs to be reviewed labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:new This issue needs to be reviewed type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant