Skip to content

chore(ci): add job to push new version to chocolatey #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

gg-jonathangriffe
Copy link
Contributor

@gg-jonathangriffe gg-jonathangriffe commented Apr 2, 2025

What has been done

A job was added to automatically publish new ggshield versions on chocolatey.
This MR also introduces the ggshield.nuspec used for the ggshield chocolatey package.

Validation

  • Test the push-to-chocolatey script
  • Download the nupkg and install it on a windows VM with "choco install ggshield -source ."

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (6761a1e) to head (8cfd075).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files         144      144           
  Lines        6066     6066           
=======================================
  Hits         5574     5574           
  Misses        492      492           
Flag Coverage Δ
unittests 91.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gg-jonathangriffe gg-jonathangriffe force-pushed the jgriffe/add-ci-push-to-choco-job branch from c399529 to 80de3df Compare April 3, 2025 12:18
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remark on the description, but looks good. Approved. You can merge when it's fixed.

@sevbch
Copy link
Collaborator

sevbch commented Apr 4, 2025

I didn't actually review, but I was thinking this could be definitely worth a changelog entry, to say ggshield will now be available on chocolatey! 🍫

WDTY?

Edit: you can also mention #934 in the changelog entry

@gg-jonathangriffe gg-jonathangriffe force-pushed the jgriffe/add-ci-push-to-choco-job branch 3 times, most recently from 2eb2a7e to c642d40 Compare April 9, 2025 08:58
@gg-jonathangriffe gg-jonathangriffe force-pushed the jgriffe/add-ci-push-to-choco-job branch from c642d40 to 8cfd075 Compare April 9, 2025 09:00
@agateau-gg agateau-gg linked an issue Apr 9, 2025 that may be closed by this pull request
@agateau-gg agateau-gg merged commit b6b8ab7 into main Apr 9, 2025
52 of 53 checks passed
@agateau-gg agateau-gg deleted the jgriffe/add-ci-push-to-choco-job branch April 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Chocolatey Installation Package
4 participants