-
Notifications
You must be signed in to change notification settings - Fork 20
Go: Fix GoLang queries #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…rityLab/CodeQL-Community-Packs into geekmasher-go-queries
…rityLab/CodeQL-Community-Packs into geekmasher-go-queries
felickz
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency Updates - run
codeql pack upgrade
go/lib/codeql-pack.lock.yml
,go/src/codeql-pack.lock.yml
, andgo/test/codeql-pack.lock.yml
: Updated the versions of dependencies includingcodeql/dataflow
,codeql/go-all
,codeql/mad
,codeql/ssa
,codeql/tutorial
,codeql/typetracking
, andcodeql/util
. Also, removedcodeql/go-queries
andcodeql/suite-helpers
dependencies from the test file. [1] [2] [3]Taint-Tracking Configurations:
go/src/audit/CWE-089/SqlInjectionAudit.ql
: Changed theSqlInjectionAudit
class to a private moduleConfig
that implementsDataFlow::ConfigSig
. Also, modified the taint-tracking configuration for detecting SQL injection vulnerabilities.go/src/security/CWE-078/CommandInjection.ql
: Modified theFlowConfig
module to include aisBarrier
predicate and made changes to theisSource
predicate. Also, changed the flow path in theFlowGraph
module. [1] [2]Data Flow Changes:
go/src/audit/explore/RemoteFlowSources.ql
: Changed the source of data flow fromUntrustedFlowSource
toRemoteFlowSource::Range
.go/test/security/CWE-078/cmdi.expected
: Made changes to the edges, nodes, and subpaths of the data flow.Miscellaneous Changes:
go/test/qlpack.yml
: Commented out the dependencycodeql/go-queries
.