Skip to content

Conversation

@public-glueops-renovatebot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
cloudposse/vpc/aws (source) module minor 2.2.0 -> 2.3.0

Release Notes

cloudposse/terraform-aws-vpc (cloudposse/vpc/aws)

v2.3.0

Compare Source

Fixes "Error: no association of default Security Group (sg-XXX) with VPC Endpoint (vpce-YYY)" @​j4zzcat (#​158) This PR updates the `vpc-endpoints` module to prevent recurring no association of default Security Group (...) with VPC Endpoint (...) errors when managing Interface VPC Endpoints. See also https://github.com/cloudposse-terraform-components/aws-vpc/issues/49.

The issue occurred because AWS automatically attaches the default VPC security group to an Interface endpoint when no SGs are specified at creation. The module previously relied on replace_default_association to swap it out for the desired SG. This worked only on the first run - subsequent runs failed because the default SG was no longer attached.

Changes

  1. Attach first SG at creation time
    • Added security_group_ids to aws_vpc_endpoint.interface_endpoint with the first SG from var.interface_vpc_endpoints.
    • Prevents AWS from attaching the default SG and removes the need for replace_default_association.
  2. Limit SG associations to index > 0
    • Updated security_group_associations_list and security_group_associations_map locals to only include SGs beyond the first one.
    • Ensures Terraform doesn’t try to re-attach the already-attached first SG.
  3. Remove replace_default_association
    • Association resources now only attach additional SGs.
    • Eliminates fragile “replace default” logic that failed on repeated applies.

Benefits

  • Idempotent applies — no more failing after the first run.
  • Simpler logic — no special-case handling for the default SG.
  • Clean AWS state — the default SG is never attached in the first place.

Testing

  • Applied changes in a test environment with multiple endpoints and SGs.
  • Verified that:
    • First SG is attached at endpoint creation.
    • Additional SGs are attached via association resources.
    • No errors occur on repeated terraform apply runs.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@public-glueops-renovatebot public-glueops-renovatebot bot force-pushed the renovate/cloudposse-vpc-aws-2.3.x branch from 59ceefb to 4e06e73 Compare September 24, 2025 10:26
@github-actions github-actions bot removed the patch label Sep 24, 2025
@public-glueops-renovatebot public-glueops-renovatebot bot force-pushed the renovate/cloudposse-vpc-aws-2.3.x branch 2 times, most recently from 1091d43 to 1006489 Compare October 9, 2025 05:26
@public-glueops-renovatebot public-glueops-renovatebot bot force-pushed the renovate/cloudposse-vpc-aws-2.3.x branch 2 times, most recently from 8bc3af2 to 637eff6 Compare October 24, 2025 23:19
@public-glueops-renovatebot public-glueops-renovatebot bot force-pushed the renovate/cloudposse-vpc-aws-2.3.x branch from 071dd3a to 3148fc8 Compare October 25, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants