feat: Support local appearance configuration #15
Conversation
| @@ -390,6 +393,12 @@ public extension InputField { | |||
| return modifiedSelf | |||
| } | |||
|
|
|||
| func inputFieldStyle(_ appearance: InputFieldAppearance) -> Self { | |||
There was a problem hiding this comment.
I would prefer the modifier to be named .inputFieldAppearance, as "Style" reminds me of native SwiftUI modifiers, but those work in a different way, with their own Styles and Configurations. Setting the look of the input field globally is also named defaultAppearance/globalAppearance.
| func setup(with model: Model, customAppearance: InputFieldAppearance? = nil) { | ||
| if let customAppearance { | ||
| standardAppearance = customAppearance | ||
| setupAppearance() |
There was a problem hiding this comment.
I'm adding a suggestion - separating the appearance from behaviour. This is so that existing implementations in UIKit can modify the appearance in their own way (for example: one can modify the appearance by subclassing, accessing the properties, assigning a new appearance proxy or even by modifying the UIKit hierarchy directly). We've got all kinds of mess in our projects, and I hope this should make it more compatible.
Also it supports the "separation of responsibilities" principle, since setting the appearance will be its own function, decoupled from the "model"/traits of the input field.
| func setup(with model: Model, customAppearance: InputFieldAppearance? = nil) { | |
| if let customAppearance { | |
| standardAppearance = customAppearance | |
| setupAppearance() | |
| func setupAppearance(_ appearance: InputFieldAppearance) { | |
| standardAppearance = customAppearance | |
| setupAppearance() | |
| } | |
| func setup(with model: Model) { |
There was a problem hiding this comment.
@plajdo made good points I don't have anything else to add but I do agree with his suggestions.
|
Note to self: needs to be updated before merging to prevent introducing breaking changes/conflicts |
Changes:
InputFieldby using.inputFieldStyle(.custom)modifier.configureAppearanceremains.Screenshots:
https://github.com/user-attachments/assets/223a842b-2b1d-4e71-a8ad-7837e49e74b7