-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add monitor script to list model IDs on a host & associated GPU memory usage #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe changes include downgrading the CUDA runtime base image from version 12.5.0 to 12.4.1 in both the DaemonSet template and the Dockerfile. The Dockerfile is further simplified by removing the installation and usage of Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (2)
chart/templates/daemonset.yaml (2)
41-43
:monitor.sh
never runsThe container still sleeps forever; the new monitoring script is never invoked.
Replaceargs
with something like:command: ["/bin/bash", "-c", "./monitor.sh"]or append the script before the sleep so logs are produced.
38-41
: Drop the unused host volume
/host
is no longer referenced (nerdctl logic removed). Mounting the entire host root is a big security surface—delete thevolumeMount
andhostPath
sections.Also applies to: 44-47
🧹 Nitpick comments (2)
chart/templates/daemonset.yaml (1)
26-28
: Re-evaluate privileges
hostPID: true
is required forps
, buthostIPC: true
adds no value to the script. Consider removing it to minimise namespace exposure.scripts/monitor.sh (1)
3-4
: Harden the script flagsUse
set -Eeuo pipefail
for safer error handling and to catch pipeline failures.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
chart/templates/daemonset.yaml
(2 hunks)nvidia-monitor.Dockerfile
(1 hunks)scripts/monitor.sh
(1 hunks)
Script demo
Commits
Legal Boilerplate
Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.