Skip to content

Conversation

nikochiko
Copy link
Member

@nikochiko nikochiko commented Aug 8, 2025

Script demo

image

Commits

  • fix: update cuda version for nvidia-monitor, fix installation script
  • feat: use monitoring script that lists memory usage along with used models

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

Copy link

coderabbitai bot commented Aug 8, 2025

📝 Walkthrough

Walkthrough

The changes include downgrading the CUDA runtime base image from version 12.5.0 to 12.4.1 in both the DaemonSet template and the Dockerfile. The Dockerfile is further simplified by removing the installation and usage of nerdctl, and instead, it now copies a new script, monitor.sh, into the image. The monitor.sh script is newly introduced and is designed to display GPU memory usage per process, extracting model identifiers from environment variables or process command lines.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • The changes involve a straightforward image version downgrade, Dockerfile simplification, and the addition of a single medium-complexity Bash script.
  • The new script introduces logic to parse GPU usage and extract metadata, requiring moderate review, but the overall scope remains limited.

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-nvidia-monitor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nikochiko nikochiko requested a review from devxpy August 8, 2025 11:50
@nikochiko nikochiko changed the title fix nvidia monitor feat: add monitor script to list model IDs on a host & associated GPU memory usage Aug 8, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🔭 Outside diff range comments (2)
chart/templates/daemonset.yaml (2)

41-43: monitor.sh never runs

The container still sleeps forever; the new monitoring script is never invoked.
Replace args with something like:

command: ["/bin/bash", "-c", "./monitor.sh"]

or append the script before the sleep so logs are produced.


38-41: Drop the unused host volume

/host is no longer referenced (nerdctl logic removed). Mounting the entire host root is a big security surface—delete the volumeMount and hostPath sections.

Also applies to: 44-47

🧹 Nitpick comments (2)
chart/templates/daemonset.yaml (1)

26-28: Re-evaluate privileges

hostPID: true is required for ps, but hostIPC: true adds no value to the script. Consider removing it to minimise namespace exposure.

scripts/monitor.sh (1)

3-4: Harden the script flags

Use set -Eeuo pipefail for safer error handling and to catch pipeline failures.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e04d993 and 0dae8a2.

📒 Files selected for processing (3)
  • chart/templates/daemonset.yaml (2 hunks)
  • nvidia-monitor.Dockerfile (1 hunks)
  • scripts/monitor.sh (1 hunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants