fix: rollback in handle_disconnect_extension

Author: milovate

daras_ai_v2/twilio_bot.py

@@ -346,14 +346,9 @@ def handle_disconnect_extension(text: str, user_id: str, convo: Conversation):
     if text.lower() in ["/disconnect"]:
         with transaction.atomic():
             extensions = BotExtensionUser.objects.filter(twilio_phone_number=user_id)
-            if extensions.exists():
-                count = extensions.count()
-                extensions.delete()
+            count = extensions.delete()[0]
+            logger.info(f"Deleted {count} extension(s) for phone number: {user_id}")
 
-                logger.info(f"Deleted {count} extension(s) for phone number: {user_id}")
-
-                convo.reset_at = timezone.now()
-                convo.save()
-                raise ExtensionGatheringSMS("Extension disconnected")
-            else:
-                logger.info(f"No extension found for phone number: {user_id}")
+            convo.reset_at = timezone.now()
+            convo.save()
+        raise ExtensionGatheringSMS("Extension disconnected")

number_cycling/utils.py

@@ -21,7 +21,9 @@ def generate_unique_extension_number(
     for attempt in range(5):
         seed = seed + attempt
         hashid = extension_hashids.encode(seed)
-        extension_number = abs(hash(hashid)) % (10**length)
+        extension_number = (10 ** (length - 1)) + (
+            abs(hash(hashid)) % (10 ** (length - 1))
+        )
 
         try:
             with transaction.atomic():