-
Notifications
You must be signed in to change notification settings - Fork 3
Remove prompt and clean up additional label creations #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please remove the expander too because of streamlit/streamlit#5604 |
Then we need to keep the email settings fields out in open coz hiding it in the if of checkbox results in wiping the state all together. Screen.Recording.2022-10-28.at.19.50.44.mov |
Cool remove the hiding thingy then, and later file a bug report on streamlit too |
it is a bug right ? 😅 it should not wipe from the session_state. |
You'll only find that out if you create a minimum reproducible example |
Ah totally forgot. Please remove the save button there too! |
Is it because we save everything on a successful run? |
Yes, otherwise settings are different than outputs |
Done |
@devxpy submitted a bug streamlit/streamlit#5620 for this |
🚀 |
…when send_email is off