Skip to content

Conversation

devxpy
Copy link
Member

@devxpy devxpy commented Oct 28, 2022

…when send_email is off

@devxpy
Copy link
Member Author

devxpy commented Oct 28, 2022

image

@devxpy
Copy link
Member Author

devxpy commented Oct 28, 2022

Please remove the expander too because of streamlit/streamlit#5604

@isinghmitesh
Copy link
Contributor

Then we need to keep the email settings fields out in open coz hiding it in the if of checkbox results in wiping the state all together.

Screen.Recording.2022-10-28.at.19.50.44.mov

@devxpy
Copy link
Member Author

devxpy commented Oct 28, 2022

Cool remove the hiding thingy then, and later file a bug report on streamlit too

@isinghmitesh
Copy link
Contributor

it is a bug right ? 😅 it should not wipe from the session_state.

@devxpy
Copy link
Member Author

devxpy commented Oct 28, 2022

You'll only find that out if you create a minimum reproducible example

@devxpy
Copy link
Member Author

devxpy commented Oct 28, 2022

Ah totally forgot. Please remove the save button there too!

@isinghmitesh
Copy link
Contributor

Is it because we save everything on a successful run?

@devxpy
Copy link
Member Author

devxpy commented Oct 28, 2022

Yes, otherwise settings are different than outputs

@isinghmitesh
Copy link
Contributor

Done

@isinghmitesh
Copy link
Contributor

Then we need to keep the email settings fields out in open coz hiding it in the if of checkbox results in wiping the state all together.

Screen.Recording.2022-10-28.at.19.50.44.mov

@devxpy submitted a bug streamlit/streamlit#5620 for this

@devxpy devxpy merged commit f5365fe into master Oct 28, 2022
@devxpy devxpy deleted the mitesh branch October 28, 2022 17:26
@devxpy
Copy link
Member Author

devxpy commented Oct 28, 2022

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants