-
Notifications
You must be signed in to change notification settings - Fork 3
Sidebar layout #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anish-work
wants to merge
16
commits into
master
Choose a base branch
from
sidebar_layout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sidebar layout #745
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1cd4344
add sidebar layout to page_wrapper
anish-work 4d63659
move sidebar component locally
anish-work 3eead3d
fix workspace selector overflow
anish-work 8a5565a
fix z-index, remove down arrow, reomve close button when closed
anish-work ccf664a
fix: sidebar bugs
anish-work 01268e4
add mobile logo header back with new header
anish-work 20e5315
explore -> search
anish-work 10be70a
persist sidebar state in session
anish-work 1e08b86
remove unused properties from sidebar
anish-work 36f66f8
limit pane container width to mw-100
anish-work 72a6f4d
fix: sidebar aesthetics
anish-work cc397af
sidebar: show selected
anish-work 28e94ea
sidebar: show small google button
anish-work acdd2a5
sidebar: time hack to forget state in mobile
anish-work 35ae94b
Merge remote-tracking branch 'origin' into sidebar_layout
anish-work 4213b8f
fix: mobile sidebar position
anish-work File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid calling renderButton on a missing element (desktop container removed).
You commented out
#g_id_signin_desktopbut still invokerenderButtonfor it, which will error when the container isnull. Guard the call or remove it.async function oneTapSignin() { google.accounts.id.prompt(); - google.accounts.id.renderButton(document.getElementById("g_id_signin_desktop"), { - shape: "rectangular", - width: 200, - text: "continue_with", - size: "large", - }); + const desktopEl = document.getElementById("g_id_signin_desktop"); + if (desktopEl) { + google.accounts.id.renderButton(desktopEl, { + shape: "rectangular", + width: 200, + text: "continue_with", + size: "large", + }); + } google.accounts.id.renderButton(document.getElementById("g_id_signin_mobile"), { shape: "rectangular", width: 40, type: "icon", size: "large", }); }Also applies to: 25-33
🤖 Prompt for AI Agents