-
Notifications
You must be signed in to change notification settings - Fork 3
feat: version stats #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: version stats #783
Conversation
Warning Rate limit exceeded@devxpy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (3)
widgets/copilot_stats_plots.py (3)
23-24
: Remove unused importregex.D
This is flagged by Ruff (F401) and adds unnecessary import-time overhead. Safe to remove.
-from regex import D
96-97
: Good call to annotate version changes—ensure resilience when no published run existsIf
bi.published_run
is None,annotate_bot_versions
will raise. The function itself should guard, but if you prefer to avoid calling it in that case, wrap the call:- annotate_bot_versions(fig, bi, trunc_fn, pd_freq, dt_index, tz) + if getattr(bi, "published_run", None): + annotate_bot_versions(fig, bi, trunc_fn, pd_freq, dt_index, tz)Note: If you adopt the internal guard suggested below, this outer check becomes optional.
438-446
: Signature contains unused params (pd_freq
,tz
)They’re not used in the function body. Either use them (e.g., format dates using
tz
) or drop them to keep the API tight. If you decide to remove them, update the callsite at Lines 96-97 accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
routers/root.py
(1 hunks)widgets/copilot_stats_plots.py
(3 hunks)widgets/plotly_theme.py
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
widgets/copilot_stats_plots.py (2)
bots/models/bot_integration.py (1)
BotIntegration
(163-585)app_users/models.py (1)
full_name
(161-177)
🪛 Ruff (0.12.2)
widgets/copilot_stats_plots.py
23-23: regex.D
imported but unused
Remove unused import: regex.D
(F401)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test (3.10.12, 1.8.3)
🔇 Additional comments (2)
routers/root.py (1)
174-177
: Clearing full session on logout looks good—verify no needed state is lostFull clear is typically the right move for auth sign-out. Just confirm there’s no required post-logout UX state (e.g., banner dismissals, AB-test buckets) stored in session that you intend to keep.
widgets/plotly_theme.py (1)
29-30
: No action needed: current Plotly dependency supportshoversubplots="axis"
The project’s pyproject.toml pins Plotly at ^6.3.0 (>=6.3.0, <7.0.0), which is well above the version that introduced
hoversubplots
in 5.21 – sohoversubplots="axis"
is fully supported out of the box. (github.com)
34311f0
to
8e72748
Compare
refactor: clear entire session on logout
Q/A checklist
How to check import time?
You can visualize this using tuna:
To measure import time for a specific library:
To reduce import times, import libraries that take a long time inside the functions that use them instead of at the top of the file:
Legal Boilerplate
Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.