fix: applying plugin on an empty css file #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, I am trying to add @nuxt/fonts module into my project where I already integrated Open Props using
postcss-jit-props
plugin. It turned out the plugin cannot handle empty css file (.nuxt/nuxt-fonts-global.css
) that is auto-generated by @nuxt/fonts module and is empty when you don't specify any global font-family (which is common use case - fonts can be injected into CSS locally only where you need them).The error was:
This lead me to this repo and to
index.js
file implementation.When I added null checks for
node.first
my error disappeared (while Open Props are still being injected as expected).To have a quick fix working for me, I made a fork and created custom NPM package
elrh-postcss-jit-props
, but I believe it would be better to have it here in the official repo.I also added test as a POC (if you remove the null checks, it starts failing).
If I did something wrong, I am happy to hear a feedback.