Remove redundant location parameter from list_datasets and its callers

Author: szmikler

dataproc_jupyter_plugin/controllers/bigquery.py

@@ -54,9 +54,8 @@ async def get(self):
         try:
             page_token = self.get_argument("pageToken")
             project_id = self.get_argument("project_id")
-            location = self.get_argument("location", default="us").lower()
             bq_client = await bigquery_client.get_client(self.log)
-            dataset_list = await bq_client.list_datasets(page_token, project_id, location)
+            dataset_list = await bq_client.list_datasets(page_token, project_id)
             self.finish(json.dumps(dataset_list))
         except Exception as e:
             self.log.exception("Error fetching datasets")

dataproc_jupyter_plugin/services/bigquery.py

@@ -48,7 +48,7 @@ def create_headers(self):
             "Authorization": f"Bearer {self._access_token}",
         }
 
-    async def list_datasets(self, page_token, project_id, location):
+    async def list_datasets(self, page_token, project_id):
         try:
             if project_id == BQ_PUBLIC_DATASET_PROJECT_ID:
                 # Use BigQuery API for public datasets

dataproc_jupyter_plugin/tests/test_bigquery.py

@@ -90,8 +90,7 @@ async def test_list_datasets_public_with_page_token(
     client = Client(mock_credentials, mock_log, mock_client_session)
     result = await client.list_datasets(
         page_token="next-page",
-        project_id=BQ_PUBLIC_DATASET_PROJECT_ID,
-        location="us"
+        project_id=BQ_PUBLIC_DATASET_PROJECT_ID
     )
 
     expected_url = f"https://bigquery.googleapis.com/bigquery/v2/projects/{BQ_PUBLIC_DATASET_PROJECT_ID}/datasets?maxResults={PAGE_SIZE_LIMIT}&pageToken=next-page"
@@ -115,8 +114,7 @@ async def test_list_datasets_user_specific(
     client = Client(mock_credentials, mock_log, mock_client_session)
     result = await client.list_datasets(
         page_token=None,
-        project_id="my-project-123",
-        location="us"
+        project_id="my-project-123"
     )
 
     expected_url = f"https://dataplex.googleapis.com/v1/projects/mock-project-id/locations/global:searchEntries"
@@ -145,8 +143,7 @@ async def test_list_datasets_api_error(
     client = Client(mock_credentials, mock_log, mock_client_session)
     result = await client.list_datasets(
         page_token=None,
-        project_id="my-project-123",
-        location="us"
+        project_id="my-project-123"
     )
 
     assert result["error"] == "Error response from Dataplex: Forbidden Permission denied"

dataproc_jupyter_plugin/tests/test_bigquery_edge_cases.py

@@ -47,8 +47,7 @@ async def test_list_datasets_null_results(
     client = Client(mock_credentials, mock_log, mock_client_session)
     result = await client.list_datasets(
         page_token=None,
-        project_id="my-project-123",
-        location="us"
+        project_id="my-project-123"
     )
     assert result == {"entries": [], "nextPageToken": None}
 
@@ -71,8 +70,7 @@ async def test_list_datasets_filter_missing_dataplex_entry(
     client = Client(mock_credentials, mock_log, mock_client_session)
     result = await client.list_datasets(
         page_token=None,
-        project_id="my-project-123",
-        location="us"
+        project_id="my-project-123"
     )
     assert result["entries"] == [{"name": "entry1"}]
 

src/bigQuery/bigQueryService.tsx

@@ -147,11 +147,8 @@ export class BigQueryService {
     if (notebookValue) {
       const pageToken = nextPageToken ?? '';
       try {
-        const settings = await settingRegistry.load(PLUGIN_ID);
-        const location = settings.get('bqRegion')['composite']
-
         const data: any = await requestAPI(
-          `bigQueryDataset?project_id=${projectId}&location=${location}&pageToken=${pageToken}`
+          `bigQueryDataset?project_id=${projectId}&pageToken=${pageToken}`
         );
         if (!(data.entries || data.datasets)) {
           setDataSetResponse([]);