Fix regional datasets not showing up in Data Explorer#370
Open
szmikler wants to merge 3 commits intoGoogleCloudDataproc:mainfrom
Open
Fix regional datasets not showing up in Data Explorer#370szmikler wants to merge 3 commits intoGoogleCloudDataproc:mainfrom
szmikler wants to merge 3 commits intoGoogleCloudDataproc:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery dataset listing functionality to use the Dataplex Search API, enabling cross-region dataset discovery for user-specific projects. The changes include updating the backend to perform POST requests with search payloads and removing obsolete client-side location filtering in the frontend. Review feedback highlights that the location parameter in the list_datasets function is now redundant and should be removed, and provides a suggestion to improve the robustness of the API response parsing to handle potential null values.
Author
Author
|
I confirmed the regional datasets show up correctly now after this update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The Dataset Explorer hides zonal datasets (e.g.,
us-central1,us-east4) when the search field is empty. Only multi-zone datasets are shown. This is caused by using the regional Dataplex Entry Groups API and a strict frontend filter that excludes any dataset not matching the exactbqRegionsetting, which usually correspond to a multi-region.Solution
This PR switches the "empty search" listing to use the Dataplex Search API, matching the behavior already used for active searches.
list_datasetsto use the globalsearchEntriesendpoint for private projects, ensuring all datasets are discovered regardless of zone.bigQueryService.tsxto allow all identified datasets to be displayed.Impact
All project datasets are now visible in the explorer, regardless of their specific GCP region or zone.
Testing
Updated and verified backend tests (
test_bigquery.py); all 11 cases pass.Manual testing is currently in progress.