Skip to content

feat: added support for IPv6 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CosmicPangolin
Copy link

@kevmoo Tagging you here 'cause I figure this repo doesn't get a lot of attention. This is a trivial patch that I needed to unlock some functionalities on the Fly.io subnet, which relies heavily on IPv6 for internal resolution and load balancing. Doubt it conflicts with any GCP needs?

Copy link

google-cla bot commented Mar 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kevmoo
Copy link
Collaborator

kevmoo commented Mar 22, 2024

I think the convention on cloud run is to use IPv4 still.

I wonder if we'll have to just add a configuration option or something...

@CosmicPangolin
Copy link
Author

My understanding is that the IPv6 option covers IPv4 addresses as well (this could be documented better in the dart:io api, methinks).

@kevmoo
Copy link
Collaborator

kevmoo commented Mar 24, 2024

My understanding is that the IPv6 option covers IPv4 addresses as well (this could be documented better in the dart:io api, methinks).

It's the opposite. All ipV4 addresses are v6, but not the other way around!

@CosmicPangolin
Copy link
Author

CosmicPangolin commented Mar 25, 2024

Agreed :) I just mean InternetAddress.anyIPv6 resolves both, wrt cloud run requiring v4.

@kevmoo
Copy link
Collaborator

kevmoo commented Apr 17, 2024

it seems like tests still pass!

Would you add a changelog entry here!

Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry and bump the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants