-
Notifications
You must be signed in to change notification settings - Fork 53
feat: added support for IPv6 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I think the convention on cloud run is to use IPv4 still. I wonder if we'll have to just add a configuration option or something... |
My understanding is that the IPv6 option covers IPv4 addresses as well (this could be documented better in the dart:io api, methinks). |
It's the opposite. All ipV4 addresses are v6, but not the other way around! |
Agreed :) I just mean InternetAddress.anyIPv6 resolves both, wrt cloud run requiring v4. |
it seems like tests still pass! Would you add a changelog entry here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a changelog entry and bump the version
@kevmoo Tagging you here 'cause I figure this repo doesn't get a lot of attention. This is a trivial patch that I needed to unlock some functionalities on the Fly.io subnet, which relies heavily on IPv6 for internal resolution and load balancing. Doubt it conflicts with any GCP needs?