Conversation
|
|
||
| async def get_media_by_id( | ||
| self, item_id: int, current_user: UserModel | ||
| self, item_id: str, current_user: UserModel |
Collaborator
There was a problem hiding this comment.
Why are we changing the item_id? This should be an integer as we are using that as PK for our MediaItems on the database
| # On success, a 204 No Content response is automatically returned. | ||
|
|
||
|
|
||
| @router.get("/{asset_id}", response_model=SourceAssetResponseDto) |
Collaborator
There was a problem hiding this comment.
Are you sure this endpoint is not being used by other modules like workflows/media details/etc?
MauroCominotti
requested changes
Jan 29, 2026
Collaborator
There was a problem hiding this comment.
Hey if we haven't update package.json then let's rollback this file. This package-lock.json should ONLY be updated if we update package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new component to perform imagen upscaling.