Bumping node archives to latest stable versions #1857

distroless-bot · 2025-08-29T20:38:23Z

Signed-off-by: Distroless Bot distroless-bot@google.com

gemini-code-assist

Summary of Changes

Hello @distroless-bot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's Node.js dependency to the latest stable patch release within the 22.x series. This ensures that the build system utilizes the most current and stable version of Node.js, incorporating any bug fixes or minor improvements available in the new release.

Highlights

Node.js Version Update: The Node.js version 22.18.0 has been updated to 22.19.0 across all supported architectures (amd64, arm64, arm, ppc64le, s390x).
Checksum and URL Updates: Corresponding SHA256 checksums and download URLs for the Node.js archives have been updated to reflect the new version.
Test Data Alignment: The expected Node.js version in the test data has been updated to align with the newly bumped version.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the Node.js v22 archives from version 22.18.0 to 22.19.0. The changes are consistent across the lock file, test data, and Bazel extension file. I've suggested a refactoring in private/extensions/node.bzl to reduce code duplication and improve maintainability for future updates.

gemini-code-assist · 2025-08-29T20:40:09Z

private/extensions/node.bzl

    node_archive(
        name = "nodejs22_amd64",
-        sha256 = "a2e703725d8683be86bb5da967bf8272f4518bdaf10f21389e2b2c9eaeae8c8a",
-        strip_prefix = "node-v22.18.0-linux-x64/",
-        urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-x64.tar.gz"],
-        version = "22.18.0",
+        sha256 = "d36e56998220085782c0ca965f9d51b7726335aed2f5fc7321c6c0ad233aa96d",
+        strip_prefix = "node-v22.19.0-linux-x64/",
+        urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-x64.tar.gz"],
+        version = "22.19.0",
        architecture = "amd64",
        control = "//nodejs:control",
    )

    node_archive(
        name = "nodejs22_arm64",
-        sha256 = "d415eeea90a2fdb60c66dd386b258acbfc4d1fa4720a8df5dea7369fbdbcddee",
-        strip_prefix = "node-v22.18.0-linux-arm64/",
-        urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-arm64.tar.gz"],
-        version = "22.18.0",
+        sha256 = "d32817b937219b8f131a28546035183d79e7fd17a86e38ccb8772901a7cd9009",
+        strip_prefix = "node-v22.19.0-linux-arm64/",
+        urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-arm64.tar.gz"],
+        version = "22.19.0",
        architecture = "arm64",
        control = "//nodejs:control",
    )

    node_archive(
        name = "nodejs22_arm",
-        sha256 = "57830914581dc3640e8d95378b76c6910860f42531959e4e88eb445e0cd982b0",
-        strip_prefix = "node-v22.18.0-linux-armv7l/",
-        urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-armv7l.tar.gz"],
-        version = "22.18.0",
+        sha256 = "969037e6da2a710904d121dcb998510bc0d5d4d61d70ce5eb578096cf36c60e8",
+        strip_prefix = "node-v22.19.0-linux-armv7l/",
+        urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-armv7l.tar.gz"],
+        version = "22.19.0",
        architecture = "arm",
        control = "//nodejs:control",
    )

    node_archive(
        name = "nodejs22_ppc64le",
-        sha256 = "38f965cbaa5e730dbd3b1afe895cfdb86da96371474827d05d847d338a0c9c97",
-        strip_prefix = "node-v22.18.0-linux-ppc64le/",
-        urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-ppc64le.tar.gz"],
-        version = "22.18.0",
+        sha256 = "b18b05265c5586e0a7797831ed747eeac7300fd2c495b8b5276596823b076e12",
+        strip_prefix = "node-v22.19.0-linux-ppc64le/",
+        urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-ppc64le.tar.gz"],
+        version = "22.19.0",
        architecture = "ppc64le",
        control = "//nodejs:control",
    )

    node_archive(
        name = "nodejs22_s390x",
-        sha256 = "f3578b0e7cdf247045f6eeb766febd74942954352161102cb6040a4d4c3b4c3c",
-        strip_prefix = "node-v22.18.0-linux-s390x/",
-        urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-s390x.tar.gz"],
-        version = "22.18.0",
+        sha256 = "d434665268adf0670a36676f5f3f46aaf5e13aad3fc81dac87119e871745bf22",
+        strip_prefix = "node-v22.19.0-linux-s390x/",
+        urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-s390x.tar.gz"],
+        version = "22.19.0",
        architecture = "s390x",
        control = "//nodejs:control",
    )


The definitions for Node.js version 22 archives are very repetitive. You can refactor this block to use a loop over a data structure, which would make it more concise and easier to maintain. This would also reduce the chance of errors when updating versions in the future.

Suggested change

node_archive(

name = "nodejs22_amd64",

sha256 = "a2e703725d8683be86bb5da967bf8272f4518bdaf10f21389e2b2c9eaeae8c8a",

strip_prefix = "node-v22.18.0-linux-x64/",

urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-x64.tar.gz"],

version = "22.18.0",

sha256 = "d36e56998220085782c0ca965f9d51b7726335aed2f5fc7321c6c0ad233aa96d",

strip_prefix = "node-v22.19.0-linux-x64/",

urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-x64.tar.gz"],

version = "22.19.0",

architecture = "amd64",

control = "//nodejs:control",

)

node_archive(

name = "nodejs22_arm64",

sha256 = "d415eeea90a2fdb60c66dd386b258acbfc4d1fa4720a8df5dea7369fbdbcddee",

strip_prefix = "node-v22.18.0-linux-arm64/",

urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-arm64.tar.gz"],

version = "22.18.0",

sha256 = "d32817b937219b8f131a28546035183d79e7fd17a86e38ccb8772901a7cd9009",

strip_prefix = "node-v22.19.0-linux-arm64/",

urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-arm64.tar.gz"],

version = "22.19.0",

architecture = "arm64",

control = "//nodejs:control",

)

node_archive(

name = "nodejs22_arm",

sha256 = "57830914581dc3640e8d95378b76c6910860f42531959e4e88eb445e0cd982b0",

strip_prefix = "node-v22.18.0-linux-armv7l/",

urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-armv7l.tar.gz"],

version = "22.18.0",

sha256 = "969037e6da2a710904d121dcb998510bc0d5d4d61d70ce5eb578096cf36c60e8",

strip_prefix = "node-v22.19.0-linux-armv7l/",

urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-armv7l.tar.gz"],

version = "22.19.0",

architecture = "arm",

control = "//nodejs:control",

)

node_archive(

name = "nodejs22_ppc64le",

sha256 = "38f965cbaa5e730dbd3b1afe895cfdb86da96371474827d05d847d338a0c9c97",

strip_prefix = "node-v22.18.0-linux-ppc64le/",

urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-ppc64le.tar.gz"],

version = "22.18.0",

sha256 = "b18b05265c5586e0a7797831ed747eeac7300fd2c495b8b5276596823b076e12",

strip_prefix = "node-v22.19.0-linux-ppc64le/",

urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-ppc64le.tar.gz"],

version = "22.19.0",

architecture = "ppc64le",

control = "//nodejs:control",

)

node_archive(

name = "nodejs22_s390x",

sha256 = "f3578b0e7cdf247045f6eeb766febd74942954352161102cb6040a4d4c3b4c3c",

strip_prefix = "node-v22.18.0-linux-s390x/",

urls = ["https://nodejs.org/dist/v22.18.0/node-v22.18.0-linux-s390x.tar.gz"],

version = "22.18.0",

sha256 = "d434665268adf0670a36676f5f3f46aaf5e13aad3fc81dac87119e871745bf22",

strip_prefix = "node-v22.19.0-linux-s390x/",

urls = ["https://nodejs.org/dist/v22.19.0/node-v22.19.0-linux-s390x.tar.gz"],

version = "22.19.0",

architecture = "s390x",

control = "//nodejs:control",

)

_NODE22_VERSION = "22.19.0"

_NODE22_ARCH_INFO = {

"amd64": ("x64", "d36e56998220085782c0ca965f9d51b7726335aed2f5fc7321c6c0ad233aa96d"),

"arm64": ("arm64", "d32817b937219b8f131a28546035183d79e7fd17a86e38ccb8772901a7cd9009"),

"arm": ("armv7l", "969037e6da2a710904d121dcb998510bc0d5d4d61d70ce5eb578096cf36c60e8"),

"ppc64le": ("ppc64le", "b18b05265c5586e0a7797831ed747eeac7300fd2c495b8b5276596823b076e12"),

"s390x": ("s390x", "d434665268adf0670a36676f5f3f46aaf5e13aad3fc81dac87119e871745bf22"),

}

for arch, (suffix, sha) in _NODE22_ARCH_INFO.items():

node_archive(

name = "nodejs22_" + arch,

sha256 = sha,

strip_prefix = "node-v{v}-linux-{s}/".format(v=_NODE22_VERSION, s=suffix),

urls = ["https://nodejs.org/dist/v{v}/node-v{v}-linux-{s}.tar.gz".format(v=_NODE22_VERSION, s=suffix)],

version = _NODE22_VERSION,

architecture = arch,

control = "//nodejs:control",

)

github-actions · 2025-08-29T20:52:33Z

🌳 🔄 Image Check

This pull request has modified the following images:

//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12

You can check the details in the report here

Signed-off-by: Distroless Bot <distroless-bot@google.com>

gemini-code-assist bot reviewed Aug 29, 2025

View reviewed changes

github-actions bot force-pushed the update-node-archives branch 2 times, most recently from 0339974 to 91249ed Compare August 31, 2025 20:37

Bumping node archives to latest stable versions

bf7ce0d

Signed-off-by: Distroless Bot <distroless-bot@google.com>

github-actions bot force-pushed the update-node-archives branch from 91249ed to bf7ce0d Compare September 1, 2025 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bumping node archives to latest stable versions #1857

Bumping node archives to latest stable versions #1857

Uh oh!

distroless-bot commented Aug 29, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 29, 2025

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

Uh oh!

Bumping node archives to latest stable versions #1857

Are you sure you want to change the base?

Bumping node archives to latest stable versions #1857

Uh oh!

Conversation

distroless-bot commented Aug 29, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

Uh oh!