Skip to content

Skaffold + Kaniko - Not error when kaniko.noPush is true #7008

@vikas027

Description

@vikas027

Expected behavior

skaffold should not fail when noPush is true under kaniko

Actual behavior

skaffold errors out with this error

INFO[0176] Skipping push to container registry due to --no-push flag 
GET https://1111111.dkr.ecr.ap-southeast-2.amazonaws.com/v2/my-image/manifests/<tag>: MANIFEST_UNKNOWN: Requested image not found
Error: Process completed with exit code 1.

Kaniko/Skaffold should not be checking whether the image has been pushed or not if .build.artifacts.[0].kaniko.noPush is true

Information

  • Skaffold version:
$ skaffold version
v1.35.1
  • Operating system:
Ubuntu 20.04.3 LTS (Focal Fossa)"
  • Installed via:
    GitHub Releases

  • Contents of skaffold.yaml:

---
apiVersion: skaffold/v2beta26
kind: Config
metadata:
  name: build-image
build:
  cluster:
<redacted>
  artifacts:
  - image: 1111111.dkr.ecr.ap-southeast-2.amazonaws.com/my-image
    kaniko:
      dockerfile: ./Dockerfile_vikas027
      noPush: true

Steps to reproduce the behavior

  1. skaffold build

Metadata

Metadata

Assignees

No one assigned

    Labels

    build/kanikohelp wantedWe would love to have this done, but don't have the bandwidth, need help from contributorskind/bugSomething isn't workingkind/documentationpriority/p3agreed that this would be good to have, but no one is available at the moment.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions