Log cmake ASAN flag #109
Merged
Log cmake ASAN flag #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmichaelis
reviewed
Oct 9, 2025
CMakeLists.txt
Outdated
Comment on lines
113
to
114
| else () | ||
| message(WARNING "ZenKit: ASAN disabled") |
There was a problem hiding this comment.
Let's only print when it's enabled since warning messages shouldn't appear in standard builds.
Suggested change
| else () | |
| message(WARNING "ZenKit: ASAN disabled") |
There was a problem hiding this comment.
Can i instead switch to message(STATUS ...) ?
Katharsas
force-pushed
the
feat/log-asan-flag
branch
from
302801c to
e28d6fa
Compare
|
That's fine, thanks :) Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So basically Visual Studio has a bug (i think) where sometimes it just ignores that I have
set(ZK_ENABLE_ASAN OFF)in my CMakeLists.txt. This log allows Visual Studio users to quickly see when this happens so they can run configure again.Not really ZenKits fault but adding this would help me (it took me a really long time to figure out this is going on)^^