Skip to content

WMIC installation #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2024
Merged

WMIC installation #127

merged 1 commit into from
Dec 30, 2024

Conversation

angyonghaseyo
Copy link
Contributor

This PR adds...

  • Installation of WMIC
  • I've kept this PR as small as possible (~500 lines) by splitting it into PRs with manageable chunks of code
  • I've requested reviews from 1 reviewer
  • I've tested existing features (website scan, sitemap, custom flow)
  • I've synced this fork with GovTechSG repo
  • I've added/updated unit tests (N.A.)
  • I've added/updated any necessary dependencies in package[-lock].json npm audit, portable installation on GitHub Actions

@younglim younglim self-requested a review December 30, 2024 06:04
younglim
younglim approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@younglim younglim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younglim younglim merged commit bae86a9 into main Dec 30, 2024
3 checks passed
@younglim younglim mentioned this pull request Jan 2, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@younglim younglim younglim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angyonghaseyo @younglim