Skip to content

Commit 10b1f1e

Browse files
committed
refactor(sidenav): top defaults to the height of masthead and navbar
1 parent f6a2ddb commit 10b1f1e

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

lib/sgds/sass/_navbar.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
@include media-breakpoint-down(lg){
88
padding: 0 $navbar-mobile-padding-y 0;
99
}
10-
min-height: 80px;
10+
min-height: $navbar-min-height;
1111
align-items: stretch;
1212

1313
a.navbar-brand {

lib/sgds/sass/_sidenav.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.sgds {
22
&.sidenav {
33
--#{$prefix}sidenav-width: #{$sidenav-width};
4-
--#{$prefix}sidenav-font-size : #{$sidenav-fontsize};
4+
--#{$prefix}sidenav-font-size: #{$sidenav-fontsize};
55
width: var(--#{$prefix}sidenav-width);
66
font-size: var(--#{$prefix}sidenav-font-size);
77

@@ -85,7 +85,9 @@
8585
}
8686
}
8787
&.sticky {
88-
--#{$prefix}sidenav-sticky-top: 0rem;
88+
--#{$prefix}sidenav-sticky-top: calc(
89+
#{$navbar-min-height} + #{$masthead-height}
90+
);
8991
position: sticky;
9092
max-height: calc(100vh - var(--#{$prefix}sidenav-sticky-top));
9193
top: var(--#{$prefix}sidenav-sticky-top);

lib/sgds/sass/_variables.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1201,6 +1201,7 @@ $nav-pills-link-active-bg: $component-active-bg !default;
12011201
$navbar-padding-y: $spacer * 2 !default;
12021202
$navbar-mobile-padding-y: $spacer !default;
12031203
$navbar-padding-x: null !default;
1204+
$navbar-min-height: 80px;
12041205

12051206
$navbar-nav-link-padding-x: .5rem !default;
12061207
$navbar-border-bottom-height: .125rem !default;
@@ -1241,6 +1242,7 @@ $navbar-dark-brand-color: $navbar-dark-active-color !default;
12411242
$navbar-dark-brand-hover-color: $navbar-dark-active-color !default;
12421243
// scss-docs-end navbar-theme-variables
12431244

1245+
$masthead-height: 28px;
12441246

12451247

12461248
// Dropdowns

0 commit comments

Comments
 (0)