Skip to content

Conversation

Peiffap
Copy link
Collaborator

@Peiffap Peiffap commented Jun 17, 2020

Supersedes the allQuest document in the summary folder on the Drive. I had to hack the "unknown year" into it, as discussed.

This is the PR I was referring to in #830. I'm also tagging #782, which is relevant as the "unknown year" document has all questions for the course, and hence this PR introduces some redundancy (which IMO is still less of a problem than having to switch back and forth between pdfs all the time).

Copy link
Collaborator

@MartinBraquet MartinBraquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca ne compile pas vu que dans mysmartcp.py, il veut parser "unkown" en int. Moi je mettrais une année au pif, en mettant un commentaire au début du doc. Sinon, ça risque de faire foirer encore, et si pas, de faire perdre notre temps précieux.

@Jimvy
Copy link
Collaborator

Jimvy commented Jun 26, 2020

Sinon ce serait pas mieux d'étendre smartcp pour gérer ce cas explicitement ? Enfin, si on trouve que ça peut être applicable à d'autres situations.

@Peiffap
Copy link
Collaborator Author

Peiffap commented Jun 26, 2020

I'm more convinced by JM's idea; there are definitely cases where such "unknown" years could occur, and it would be needlessly confusing and "dirty" to add a random year where this is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants