Make signature check case insensitive #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax the string check by converting them lowercase keytool actually prints them all in uppercase using colon separators but accounting for that is probably a bit overkill.
mags0ft
suggested changes
Feb 18, 2025
mags0ft
left a comment
mags0ft
left a comment
There was a problem hiding this comment.
A more "pythonic" way to implement case insensitive checks is comparing strings that have been modified with str.casefold().
thestinger
force-pushed
the
main
branch
4 times, most recently
from
0a26721 to
fdca615
Compare
thestinger
force-pushed
the
main
branch
2 times, most recently
from
29531c2 to
08e3f41
Compare
thestinger
force-pushed
the
main
branch
3 times, most recently
from
f9b6b19 to
c2cac33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the string check by converting them lowercase
keytool actually prints them all in uppercase using colon separators but accounting for that is probably a bit overkill.