feat: new stat chart,editing table name,quick query #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sunchanglong
commented
Dec 10, 2024
sunchanglong
commented
- feat(log): add frequency stat chart
- feat(log): add query from cell value
- fix(log): query bug
- refine(log): preserve table data when editing new query
- fix(log): support table with out ts column
ZonaHex
approved these changes
Dec 11, 2024
ZonaHex
reviewed
Dec 11, 2024
Comment on lines
208
to
+215
| if (condition.op === 'not contains') { | ||
| val = `-"${val}"` | ||
| } else if (condition.op === 'match sequence') { | ||
| } else if (condition.op === 'contains') { | ||
| val = `"${val}"` | ||
| } | ||
| return `MATCHES(${condition.field.name},'"${val}"')` | ||
| return `MATCHES(${condition.field.name},'${val}')` | ||
| } | ||
| return `${condition.field.name} ${condition.op} '"${escapeSqlString(condition.value)}"'` | ||
| return `${condition.field.name} ${condition.op} '${escapeSqlString(condition.value)}'` |
There was a problem hiding this comment.
Can this use switch case?
ZonaHex
reviewed
Dec 11, 2024
| const columnMeta = getColumnByName(columnName) | ||
| if (action === 'copy') { | ||
| await navigator.clipboard.writeText(row[columnName]) | ||
| Message.success('copy success') |
There was a problem hiding this comment.
Is text-copyable.vue appliable here? Then you don't need to send Message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.