Overhaul LightningQueryController to fix time zone conversions Ticket_1432 #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Slipping into draft mode because the Weatherbug data is now likely located in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic for aggregation to the application rather than the SQL database. This also allows us to slip a proper time zone conversion in before the aggregation rather than attempting to push a makeshift time zone conversion into the database. Instead of one subquery with four subqueries to define the slices for aggregation, we are able to do this with only two queries.
IDataReaderandIEnumerablewere used to avoid loading the full data set into memory during aggregation.TVA recently changed out their lightning database. We've received word that the
TX_LIGHTNINGschema no longer exists, and the Vaisala tables now belong to theGISschema. They also said that Weatherbug data will no longer be available.