Feat/check reloading #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2024 20:34
* isCheckType(CheckType type) -> is(CheckType type) * getCheckMask() -> getMask() * make getUnloadedBehaviour() default to return the default unloaded behaviour instance
Axionize
requested review from
MachineBreaker,
SamB440,
AoElite and
ManInMyVan
ManInMyVan
requested changes
Dec 21, 2024
src/main/java/ac/grim/grimac/api/dynamic/DefaultUnloadedBehavior.java
Outdated
Show resolved
Hide resolved
ManInMyVan
reviewed
Dec 21, 2024
Co-authored-by: ManInMyVan <113963219+ManInMyVan@users.noreply.github.com>
ManInMyVan
requested changes
Dec 22, 2024
| public int getMask() { | ||
| return mask; | ||
| } | ||
| } No newline at end of file |
|
|
||
| private final int mask; | ||
|
|
||
| CheckType(int bitPosition) { |
There was a problem hiding this comment.
you could get bitPosition from ordinal() instead of it being a constructor parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add infrastructure to support check reloading
Axionize/LightningGrim#26