Skip to content
This repository was archived by the owner on Jan 9, 2024. It is now read-only.
This repository was archived by the owner on Jan 9, 2024. It is now read-only.

ConnectionError not handled correctly if there are no connections in the pool #453

Closed
@FranGM

Description

@FranGM

Hi there!

Recently we ran into an issue where it seems like we were not handling a ConnectionError correctly and tried to call connection.disconnect() (see here ) when connection had a None value, which results in an unhandled exception being raised.

Seems like if you're using ClusterBlockingConnectionPool, and time out before a connection is available a ConnectionError will get raised, which gets mishandled in this case. The rest of the error handling seems correct to me, so I'm going to submit a PR that just checks that connection is not None before attempting to disconnect, and I'll be happy to add any other stuff that you think might be missing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions