Feat: Add set location feature with privacy enhancements #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=60&v=4){kind=small}
This commit introduces a new feature that allows members to set their location using two methods: a "Find my location" button that uses the browser's Geolocation API, and a Leaflet.js map for manual marker placement. Key changes: - Adds a new `set_location` page for members to update their location. - Integrates a Leaflet.js map for visual location selection. - Implements a "Find my location" button using the browser's Geolocation API. - Uses reverse geocoding to determine a user's suburb/city/town from coordinates. - Enhances privacy by rounding latitude and longitude to two decimal places, reducing location accuracy. - Provides a fallback mechanism for when reverse geocoding fails, storing a generic location string. - Adds comprehensive feature tests for the new functionality.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback on specific files or sections of files. For any comments you don't want me to act on, just include PS: Responding to comments on the entire PR are not yet supported but coming soon. For security, I will only act on instructions from the user who triggered this task for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#496
This change adds a "set location" feature for a user to have an optional "find my location" and leafletjs control for placing a marker at the user's location.
On finding the lat/long, use reverse geocoding to find the suburb/city/town, to store as the user's public facing location, or otherwise store the coordinates with low accuracy; to reduce privacy concerns.