Skip to content

Refactor the cmake scripts (runTest, grepTest,jrunTest) into a single script with CMake includes to break out functionality #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
byrnHDF opened this issue Apr 25, 2025 · 1 comment · May be fixed by #5538
Open

Refactor the cmake scripts (runTest, grepTest,jrunTest) into a single script with CMake includes to break out functionality #5485

byrnHDF opened this issue Apr 25, 2025 · 1 comment · May be fixed by #5538
Assignees
@byrnHDF
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 2. Medium It would be nice to have this in the next release

Comments

@byrnHDF
Copy link
Contributor

byrnHDF commented Apr 25, 2025

There is a lot of duplication in these scripts and is becoming a maintenance burden. The scripts could be broken out into single purpose macros that could be included into a single script used by the the CMake tests.
Also the main script could use the optional arguments to determine which sub-scripts get included.
@byrnHDF byrnHDF added Component - Testing Code in test or testpar directories, GitHub workflows effort-medium Priority - 2. Medium It would be nice to have this in the next release labels Apr 25, 2025
@byrnHDF
Copy link
Contributor Author

byrnHDF commented Apr 25, 2025

A interesting SO post about calling CMake scripts from a shell script:
https://stackoverflow.com/questions/66481629/how-to-call-a-cmake-method-from-shell-script

@byrnHDF byrnHDF linked a pull request May 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byrnHDF byrnHDF

Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 2. Medium It would be nice to have this in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor run scripts to a single macros with includes byrnHDF/hdf5
3 participants
@brtnfld @byrnHDF @nbagha1