-
-
Notifications
You must be signed in to change notification settings - Fork 316
Move Java wrappers to FFM using jextract and java 25 #5957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 250 commits
Commits
Show all changes
444 commits
Select commit
Hold shift + click to select a range
f6029d3
Committing clang-format changes
github-actions[bot] 5a5d122
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 74227e2
Initial work on FFM tests
byrnHDF 26ef1cb
Committing clang-format changes
github-actions[bot] 18c55b2
Cleanup and add H5P tests
byrnHDF 7979601
Committing clang-format changes
github-actions[bot] fdc577d
Fix conflicts
byrnHDF 534e3d2
Committing clang-format changes
github-actions[bot] cfe3788
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF f6520a7
Remove unneeded testfiles
byrnHDF ad092d8
Add more H5P tests
byrnHDF a3eb203
Committing clang-format changes
github-actions[bot] 4746349
More H5P tests
byrnHDF 28b9106
Committing clang-format changes
github-actions[bot] 3274574
Add more H5P tests
byrnHDF 621171b
Committing clang-format changes
github-actions[bot] 8c91274
Rework depends name
byrnHDF 63d7fe8
Add more H5A tests
byrnHDF f1f2178
Committing clang-format changes
github-actions[bot] 8753db9
Implement more tests
byrnHDF 39fd3d3
Committing clang-format changes
github-actions[bot] f18e0e5
Fix JNI depends usage
byrnHDF 979f86b
Attempt to fix doxygen ref issue
byrnHDF c79c21a
Add more checks
byrnHDF 85931ca
Correct ENABLE JNI usage
byrnHDF e0dd033
re-enable docs for fixing
byrnHDF a0c354e
Merge develop chnages
byrnHDF 3235570
Committing clang-format changes
github-actions[bot] 41ec545
Update FFM source
byrnHDF 6cbe8a9
Committing clang-format changes
github-actions[bot] 2b5f3c8
Try fix win CI
byrnHDF 1b17ff5
Must be shared lib
byrnHDF 2199178
Merge H5EX prefix change
byrnHDF 03e2fa3
Fix usage variable to function call
byrnHDF 2bf4a3f
Merge with develop changes
byrnHDF 0e39b50
Updates
byrnHDF 19a4ba4
Committing clang-format changes
github-actions[bot] 73cd784
Corrections everywhere
byrnHDF 33546ac
Committing clang-format changes
github-actions[bot] 893f9b5
More FFM tests
byrnHDF ee1a0b2
Committing clang-format changes
github-actions[bot] 13e29d3
Fix constants option
byrnHDF 5015bb3
Committing clang-format changes
github-actions[bot] 2b6f7a3
Require ros3 for ffm java
byrnHDF 0b24486
Committing clang-format changes
github-actions[bot] 69389eb
Merge branch 'develop'
byrnHDF 7634eaa
Fix conflicts
byrnHDF 6dd92b1
remove duplicates
byrnHDF 7af8277
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF d50ecdc
Skip including ros3 VFD APIs
byrnHDF 2a69cde
Committing clang-format changes
github-actions[bot] fab29a7
Fix workflow
byrnHDF 03ba0e4
Remove obsolete file
byrnHDF b7eba50
Update java jar usage
byrnHDF 82b8b73
Check for artifacts before creating again
byrnHDF 4cc7123
Rework how to use FFM headers
byrnHDF d593a48
Correct version for action
byrnHDF 24d9cf8
Update artifact names for binary testing
byrnHDF 68f4cd1
Cleanup
byrnHDF 60d3fea
Add FFM H5O tests
byrnHDF 85fbcae
Committing clang-format changes
github-actions[bot] 3899d3e
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 0a4906e
Correct typo
byrnHDF 0373c00
More FFM tests for H5P and H5F
byrnHDF 0407612
Committing clang-format changes
github-actions[bot] 48b1c7a
Add some H5T ffm tests
byrnHDF 1887a84
Committing clang-format changes
github-actions[bot] 62f5cbb
Remove duplicate test
byrnHDF d179c72
Split HDF5Examples into FFM and compatibility
byrnHDF 3ecb327
Committing clang-format changes
github-actions[bot] 244299d
adjust ros3 file location
byrnHDF 856d499
More FFM tests
byrnHDF 87e356c
Committing clang-format changes
github-actions[bot] 752ae4d
Optionally include structs file
byrnHDF 5f99cb0
Fix FFM test issues
byrnHDF 1590ef9
Committing clang-format changes
github-actions[bot] 3ccb360
More tests added
byrnHDF 855fb27
Committing clang-format changes
github-actions[bot] 8208e55
Fix merge conflicts
byrnHDF d839b84
Committing clang-format changes
github-actions[bot] 57abf99
Add H5VL ffm tests
byrnHDF f53608e
Committing clang-format changes
github-actions[bot] d0a468e
Cover more API modules.
byrnHDF 31550ad
Committing clang-format changes
github-actions[bot] 8e9c768
Fix install logic
byrnHDF ed4afa4
Update tests
byrnHDF 65523ae
Committing clang-format changes
github-actions[bot] 1df7388
Add presets
byrnHDF c2bd155
More tests implemented
byrnHDF 5d5b013
Committing clang-format changes
github-actions[bot] a5486c5
Finish FFM tests
byrnHDF 61fdfa1
Committing clang-format changes
github-actions[bot] 4a86808
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 293c740
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 7066c5d
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 74e82da
Fix merge conflicts
byrnHDF 1a69419
Committing clang-format changes
github-actions[bot] 912bf9f
First examples for FFM
byrnHDF 739404f
Committing clang-format changes
github-actions[bot] b2555f2
All examples converted
byrnHDF 706cfff
Committing clang-format changes
github-actions[bot] f764403
Enable Java FFM examples
byrnHDF f255349
Add windows jextract files
byrnHDF 407ae57
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF b741ee6
Update INSTALL docs - make presets primary
byrnHDF 9a6fbea
Correct version check for examples
byrnHDF 98bd481
Fix FFM examples
byrnHDF 6f5352a
Committing clang-format changes
github-actions[bot] d4e771c
Update FFM examples
byrnHDF 78ef1d6
Committing clang-format changes
github-actions[bot] 7b634c6
Fix tutor examples
byrnHDF 9050020
Do not build iterate/visit FFM examples
byrnHDF e026baf
Committing clang-format changes
github-actions[bot] f762db5
Fix more examples
byrnHDF aa66663
correct typo
byrnHDF bd868ac
Committing clang-format changes
github-actions[bot] b226552
Some more fixes
byrnHDF a432632
Committing clang-format changes
github-actions[bot] 9aca060
Fix TUTR compile issues
byrnHDF 872315e
Committing clang-format changes
github-actions[bot] 4c412fa
Update test name
byrnHDF 6494e68
Correct default java state
byrnHDF 05661e3
Complete examples.
byrnHDF fd4d057
Committing clang-format changes
github-actions[bot] 02381f4
Update presets
byrnHDF 1b8b3c6
Skip example with missing file
byrnHDF 2014531
Add tests to presets
byrnHDF 3fc0003
Add workflow to create FFM bindings.
byrnHDF fc40753
Integrate FFM bindings generation into daily build workflow
byrnHDF 5e25826
Update CLAUDE.md with daily build integration
byrnHDF d54d64a
Fix jextract download with fallback URLs
byrnHDF b4a50a9
Update jextract URLs to current builds
byrnHDF 90f3687
Fix broken pipe error in ls output
byrnHDF f326036
Remove unnecessary ls commands from jextract workflow
byrnHDF f8128d4
Add ROS3 VFD support to FFM bindings generation workflow
byrnHDF 7e13b4b
Fix Windows jextract extraction issue
byrnHDF 0dd52f3
Fix Windows jextract extraction with adaptive path detection
byrnHDF 24b1a8a
Fix Windows jextract to use .bat file instead of .exe
byrnHDF 4d97031
Fix Windows install prefix path format for bash shell
byrnHDF 300ca9a
Fix merge step to download only jextract artifacts
byrnHDF 417ad46
Fix merge script to handle platform-specific FFM bindings
byrnHDF 298b887
Correct version for examples
byrnHDF 9aec4e3
FFM platform files.
byrnHDF 0b9dae3
Committing clang-format changes
github-actions[bot] 3d0c5eb
Fix script
byrnHDF ffabacf
Correct file list
byrnHDF e794f95
Correct path to files
byrnHDF fa8d793
Add missing folder
byrnHDF 79bb3df
Fix windows compile issue
byrnHDF b3c01d8
Committing clang-format changes
github-actions[bot] 442c691
Fix doxygen error
byrnHDF b4808ec
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 282cd85
Fix maven-staging workflow: Add missing graphviz dependency
byrnHDF 6ac3b74
Fix HDF5Examples to properly detect JNI vs FFM implementation
byrnHDF 274b8bb
Correct doxygen tags
byrnHDF ec0fd36
Skip Windows-failing FFM tests in TestH5Tffm
byrnHDF f14f59b
Committing clang-format changes
github-actions[bot] 4e0efc8
Fix HDF5Examples to correctly detect JNI vs FFM using HDF5_JAVA_IMPLE…
byrnHDF 3dcfa4c
Fix Windows FFM test failures by using platform-independent H5T_STD t…
byrnHDF e601e2d
Enable detailed test output for FFM Java tests
byrnHDF dcee9c2
Fix Maven minimal presets: Remove test step when BUILD_TESTING=OFF
byrnHDF f55df49
Add compilation error output to Maven staging test failures
byrnHDF 9ae3b54
Fix Maven staging to use correct examples directory based on implemen…
byrnHDF a9acd55
Fix Maven staging Windows test to check all 4 example categories
byrnHDF 52e43ea
Clarify Maven preset platform-specificity in INSTALL_CMake.txt
byrnHDF d1fd3e7
Skip 5 Windows-failing FFM tests - FFM memory layout limitations
byrnHDF 355cccd
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 55ae3c8
Improve presets usage
byrnHDF 5c3057d
Change NATIVE types
byrnHDF 3a59485
Fix workflow
byrnHDF 758f7b6
Fix maven staging workflow
byrnHDF edf0c12
More fixes for maven workflow
byrnHDF e23cbab
Fix windows LONG errors
byrnHDF 249db7c
Committing clang-format changes
github-actions[bot] 40048c8
Correct maven staging workflow
byrnHDF 41e0455
Improve maven testing
byrnHDF 8ea0e0a
Another fix to test
byrnHDF 8b05236
Fix for implentation tests
byrnHDF e0c39ee
Fix test binaries
byrnHDF dcfa3bc
Correct option usage.
byrnHDF 33f3721
Fix FFM binary tests
byrnHDF 1781e36
Correct java version for bintest.yml
byrnHDF 05a0b00
Fix relative paths in jni source
byrnHDF 53aa605
Fix maven artifacts for release workflow
byrnHDF ae7a885
Merge branch 'HDFGroup:develop' into develop-jextract22
byrnHDF 4098ea9
Revert Maven changes from ctest.yml
byrnHDF 2ed7ec9
Remove maven_enabled parameter from release.yml ctest call
byrnHDF 65fb9ad
Fix Java version mismatch in macOS binary tests
byrnHDF fd7518c
Fix Java build failures in release workflow standard builds
byrnHDF 41f8226
Fix java build race condition issue
byrnHDF 9d3605e
Clean up CLAUDE.md: remove date-specific and test-specific info
byrnHDF 9af5b17
Cleanup doc and set default
byrnHDF d75b375
Refactor out aws_c_s3 workflow
byrnHDF 924d0d5
Cleanup preset naming and usage
byrnHDF b2339d5
Correct preset names in script
byrnHDF 229a2bf
Convert FFM to generate inline and use jextract-25
byrnHDF 2bf37fe
Committing clang-format changes
github-actions[bot] d169f16
Update workflows for jextract
byrnHDF 6a61b15
Add jextract error handling
byrnHDF a366b3d
Update jextract on windows
byrnHDF 1ff1772
Add way to check for features
byrnHDF ffeb059
Committing clang-format changes
github-actions[bot] 704856c
Use reflection-based helper methods for java compat constants
byrnHDF 4a69dc4
Committing clang-format changes
github-actions[bot] e30eccc
Update testing and compat functions
byrnHDF b950236
Committing clang-format changes
github-actions[bot] f3538b4
Remove obsolete workflows/scripts and fix maven scripts
byrnHDF 5072f09
Merge branch 'HDFGroup:develop' into develop-jextract25
byrnHDF 2d2f034
Update java based on merge for default 1.8 libver
byrnHDF 18e1997
Add comprehensive Java/Maven documentation to doxygen
byrnHDF 6e62cd8
Fix Maven validation script to handle FFM bindings JAR
byrnHDF 48734f4
Merge doc develop changes
byrnHDF a369db3
Merge branch 'HDFGroup:develop' into develop-jextract25
byrnHDF a9a6592
Remove tmp files
byrnHDF 9067590
Use Java 25 for all FFM binary tests
byrnHDF 9fa5a74
Make Java 25 the minimum requirement for FFM builds
byrnHDF c41aaec
Remove more files
byrnHDF 30a4df7
Remove vague text about static
byrnHDF 85e831c
Remove static reference
byrnHDF 37629c4
Fix FFM cache setting
byrnHDF dec12fb
Fix java option and correct java 25 req
byrnHDF 94ced1d
correct java version number for checks
byrnHDF 01481f1
Update test scripts to require Java 25 for FFM
byrnHDF b55e85c
Update workflows for java 25 and not 24
byrnHDF 6f24185
Clean up comments in VLDataConverter.java
byrnHDF 912bf2e
Committing clang-format changes
github-actions[bot] a99fac1
cleanup
byrnHDF d122c0d
Remove claude file refs
byrnHDF 2c75abd
Fix incorrect variables
byrnHDF 7181e0d
Remove unused script
byrnHDF a67ca11
Merge branch 'HDFGroup:develop' into develop-jextract25
byrnHDF d6a0fa9
Update Pfapl tests
byrnHDF b1eaff2
Delete CLAUDE.md
byrnHDF a989f64
Address multiple review comments
byrnHDF 1e79dee
Merge branch 'develop' into develop-jextract25
byrnHDF f3eff4b
Update actions versions
byrnHDF 66f27c1
Fix typo
byrnHDF c361a45
Ignore failing VL FFM compat tests - address reviews
byrnHDF e2426c5
Committing clang-format changes
github-actions[bot] 1f61789
Merge in FP8 changes
byrnHDF 1110f29
Merge in FP non-java changes
byrnHDF 02acb61
Add files temp
byrnHDF 8f76355
Merge branch 'HDFGroup:develop' into develop-jextract25
byrnHDF a863bb7
Remove temp
byrnHDF 8d113cc
Fix ros3 fapl access for compat class and tests
byrnHDF 7faff4b
Committing clang-format changes
github-actions[bot] c995e82
Fix doxygen error
byrnHDF 5cc63c9
Merge branch 'HDFGroup:develop' into develop-jextract25
byrnHDF f305ecf
Merge branch 'HDFGroup:develop' into develop-jextract25
byrnHDF ebe6d49
remove uneeded file
byrnHDF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| name: 'Setup jextract' | ||
| description: 'Install jextract for FFM binding generation across all platforms' | ||
| inputs: | ||
| java-version: | ||
| description: 'Java version for jextract (24, 25, latest)' | ||
| required: false | ||
| default: '25' | ||
|
|
||
| outputs: | ||
| jextract-home: | ||
| description: 'Path to jextract installation' | ||
| value: ${{ steps.setup-jextract.outputs.jextract-home }} | ||
| jextract-version: | ||
| description: 'Version of jextract installed' | ||
| value: ${{ steps.setup-jextract.outputs.jextract-version }} | ||
|
|
||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - name: Setup jextract (Linux/macOS) | ||
| id: setup-jextract-unix | ||
| if: runner.os != 'Windows' | ||
| shell: bash | ||
| run: | | ||
| echo "Installing jextract for $RUNNER_OS..." | ||
|
|
||
| # Determine platform | ||
| if [[ "$RUNNER_OS" == "macOS" ]]; then | ||
| PLATFORM="macos-x64" | ||
| else | ||
| PLATFORM="linux-x64" | ||
| fi | ||
|
|
||
| # Try different jextract versions (from latest to older) | ||
| # Check https://jdk.java.net/jextract/ for available builds | ||
| JEXTRACT_URLS=( | ||
| "https://download.java.net/java/early_access/jextract/22/6/openjdk-22-jextract+6-47_${PLATFORM}_bin.tar.gz" | ||
| "https://download.java.net/java/early_access/jextract/21/5/openjdk-21-jextract+5-31_${PLATFORM}_bin.tar.gz" | ||
| "https://download.java.net/java/early_access/jextract/20/1/openjdk-20-jextract+1-2_${PLATFORM}_bin.tar.gz" | ||
| ) | ||
|
|
||
| mkdir -p $HOME/jextract | ||
| cd $HOME/jextract | ||
|
|
||
| SUCCESS=false | ||
| for URL in "${JEXTRACT_URLS[@]}"; do | ||
| echo "Trying to download from: $URL" | ||
| if curl -L -f -o jextract.tar.gz "$URL" 2>/dev/null; then | ||
| echo "✓ Download successful from $URL" | ||
| tar -xzf jextract.tar.gz --strip-components=1 | ||
| rm jextract.tar.gz | ||
| SUCCESS=true | ||
| break | ||
| else | ||
| echo "✗ Failed to download from $URL, trying next..." | ||
| fi | ||
| done | ||
|
|
||
| if [ "$SUCCESS" = false ]; then | ||
| echo "ERROR: Failed to download jextract from any known source" | ||
| echo "Please check https://jdk.java.net/jextract/ for available builds" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Set outputs | ||
| echo "jextract-home=$HOME/jextract" >> $GITHUB_OUTPUT | ||
|
|
||
| # Verify installation | ||
| if $HOME/jextract/bin/jextract --version 2>&1; then | ||
| VERSION=$($HOME/jextract/bin/jextract --version 2>&1 | head -1 || echo "unknown") | ||
| echo "jextract-version=$VERSION" >> $GITHUB_OUTPUT | ||
| echo "✓ jextract installed successfully: $VERSION" | ||
| else | ||
| echo "jextract-version=unknown" >> $GITHUB_OUTPUT | ||
| echo "✓ jextract installed (version check not supported)" | ||
| fi | ||
|
|
||
| - name: Setup jextract (Windows) | ||
| id: setup-jextract-windows | ||
| if: runner.os == 'Windows' | ||
| shell: pwsh | ||
| run: | | ||
| Write-Host "Installing jextract for Windows..." | ||
|
|
||
| # Try multiple jextract versions (latest to older) | ||
| # Windows now uses .tar.gz format | ||
| $JextractUrls = @( | ||
| "https://download.java.net/java/early_access/jextract/22/6/openjdk-22-jextract+6-47_windows-x64_bin.tar.gz", | ||
| "https://download.java.net/java/early_access/jextract/21/5/openjdk-21-jextract+5-31_windows-x64_bin.tar.gz", | ||
| "https://download.java.net/java/early_access/jextract/20/1/openjdk-20-jextract+1-2_windows-x64_bin.tar.gz" | ||
| ) | ||
|
|
||
| $JextractHome = "$env:USERPROFILE\jextract" | ||
| New-Item -ItemType Directory -Force -Path $JextractHome | Out-Null | ||
|
|
||
| $Success = $false | ||
| foreach ($Url in $JextractUrls) { | ||
| Write-Host "Trying to download from: $Url" | ||
| $TarPath = "$JextractHome\jextract.tar.gz" | ||
|
|
||
| try { | ||
| Invoke-WebRequest -Uri $Url -OutFile $TarPath -ErrorAction Stop | ||
| Write-Host "✓ Download successful from $Url" | ||
|
|
||
| # Extract using tar (available in Windows 10+) | ||
| $TempExtract = "$JextractHome\temp" | ||
| New-Item -ItemType Directory -Force -Path $TempExtract | Out-Null | ||
| tar -xzf "$TarPath" -C "$TempExtract" 2>&1 | Out-Null | ||
|
|
||
| # Find jextract.bat | ||
| $JextractBat = Get-ChildItem -Path $TempExtract -Filter "jextract.bat" -Recurse -ErrorAction SilentlyContinue | Select-Object -First 1 | ||
|
|
||
| if ($JextractBat) { | ||
| Write-Host "Found jextract.bat at: $($JextractBat.FullName)" | ||
|
|
||
| # Move contents to JextractHome | ||
| $JextractRoot = $JextractBat.Directory.Parent.FullName | ||
| Get-ChildItem -Path $JextractRoot | ForEach-Object { | ||
| Move-Item -Path $_.FullName -Destination $JextractHome -Force | ||
| } | ||
|
|
||
| # Clean up | ||
| Remove-Item -Path $TempExtract -Recurse -Force | ||
| Remove-Item -Path $TarPath -Force | ||
|
|
||
| # Verify | ||
| if (Test-Path "$JextractHome\bin\jextract.bat") { | ||
| Write-Host "✓ jextract extracted successfully to $JextractHome" | ||
| $Success = $true | ||
| break | ||
| } | ||
| } else { | ||
| Write-Host "✗ Could not find jextract.bat in extracted files" | ||
| Remove-Item -Path $TempExtract -Recurse -Force -ErrorAction SilentlyContinue | ||
| } | ||
| } | ||
| catch { | ||
| Write-Host "✗ Failed to download or extract from $Url" | ||
| Write-Host "Error: $_" | ||
| } | ||
| } | ||
|
|
||
| if (-not $Success) { | ||
| Write-Host "ERROR: Failed to download jextract from any known source" | ||
| Write-Host "Please check https://jdk.java.net/jextract/ for available builds" | ||
| exit 1 | ||
| } | ||
|
|
||
| # Set outputs | ||
| echo "jextract-home=$JextractHome" >> $env:GITHUB_OUTPUT | ||
|
|
||
| # Verify installation | ||
| try { | ||
| $Version = & "$JextractHome\bin\jextract.bat" --version 2>&1 | Select-Object -First 1 | ||
| echo "jextract-version=$Version" >> $env:GITHUB_OUTPUT | ||
| Write-Host "✓ jextract installed successfully: $Version" | ||
| } catch { | ||
| echo "jextract-version=unknown" >> $env:GITHUB_OUTPUT | ||
| Write-Host "✓ jextract installed (version check not supported)" | ||
| } | ||
|
|
||
| - name: Set environment variables | ||
| id: setup-jextract | ||
| shell: bash | ||
| run: | | ||
| if [[ "$RUNNER_OS" == "Windows" ]]; then | ||
| JEXTRACT_HOME="${{ steps.setup-jextract-windows.outputs.jextract-home }}" | ||
| JEXTRACT_VERSION="${{ steps.setup-jextract-windows.outputs.jextract-version }}" | ||
| else | ||
| JEXTRACT_HOME="${{ steps.setup-jextract-unix.outputs.jextract-home }}" | ||
| JEXTRACT_VERSION="${{ steps.setup-jextract-unix.outputs.jextract-version }}" | ||
| fi | ||
|
|
||
| echo "JEXTRACT_HOME=$JEXTRACT_HOME" >> $GITHUB_ENV | ||
| echo "jextract-home=$JEXTRACT_HOME" >> $GITHUB_OUTPUT | ||
| echo "jextract-version=$JEXTRACT_VERSION" >> $GITHUB_OUTPUT | ||
|
|
||
| # Add to PATH | ||
| if [[ "$RUNNER_OS" == "Windows" ]]; then | ||
| echo "$JEXTRACT_HOME\bin" >> $GITHUB_PATH | ||
| else | ||
| echo "$JEXTRACT_HOME/bin" >> $GITHUB_PATH | ||
| fi | ||
|
|
||
| echo "✓ jextract setup complete" | ||
| echo " JEXTRACT_HOME=$JEXTRACT_HOME" | ||
| echo " Version: $JEXTRACT_VERSION" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, we should be checking checksums.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create issue - I agree we should.