Skip to content

fixed shipping xpath #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed shipping xpath #588

wants to merge 1 commit into from

Conversation

ionimit
Copy link

@ionimit ionimit commented Mar 20, 2021

elements containing shipping price for the requested product also have "a-size-base" class

@ionimit
fixed shipping xpath
c57e8f5 
elements containing shipping price for the requested product also have "a-size-base" class
@DakkJaniels
Copy link
Collaborator

What domain are you using?

@ionimit
Copy link
Author

ionimit commented Mar 20, 2021

smile.amazon.com

timbru31
timbru31 suggested changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks if other pages do not have this class. Rather make the XPath or to check for both variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@timbru31 timbru31 timbru31 requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ionimit @DakkJaniels @timbru31