SAML: allowing idpOptions sso_urls to be parameterized #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meterized with parameters that were passed to the authorization request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR additional parameters that are passes to the authorization request, start with x_ and match a 'id-string' pattern are added to the authRequest structure that is kept in the session in a new property options. Additionally, if options have been added to the request the sso_login_url and sso_logout_url are mustache-processed with the authRequest as parameter.
This allows for idpOptions like
"sso_login_url": "https://myidp.org:/auth/SSOPOST/metaAlias/idp-{{{options.auth_realm}}}"given that the authorization request as a parameter
x_auth_realm=some-valid-value