Deck Manager and Tracker stop working and crash after sorting decks by win percentage

[prasanna2991]

Describe the bug
Deck Manager and Tracker stop working and crash after sorting decks by win percentage

To Reproduce
Steps to reproduce the behavior:

1. Have 100+ decks saved in the Deck Manager
2. Click on Sort By in the top left corner
3. Select "Win Percentage"
4. Deck Manager stops responding, and the app crashes in a few minutes or needs a force quit

Game mode

• Standard
• Wild
• Classic
• Arena
• Duels

Expected behavior
The decks should be sorted by Win Percentage. At the very least, we should be able to change the sorting criterion to prevent Deck Manager from being completely unusable

Version (please complete the following information):
Version 3.4.11 (3431)

Log file
hstracker.log

[fmoraes74]

Can you attach a crash report from your system? I don't see any on the telemetry data.

[prasanna2991]

Can you attach a crash report from your system? I don't see any on the telemetry data.

Thanks for the quick response!

I've been force-quitting the app after a few minutes so that at least the deck tracker works upon restart. I'll wait for 10-15 minutes and update here

[prasanna2991]

@fmoraes74 After 4 hours of leaving the app up, the findings are below:

1. The deck tracker was slightly laggy, and yet, it was keeping track of the games to a large extent
2. The deck manager was extremely slow. Even an attempt to scroll through the decks, clicking on a different deck, or trying to click the sort dropdown would make the deck manager fully unresponsive
3. When I checked just now, the sorting was complete, and I immediately changed the sort criterion to "Creation Date". I can see the latest decks I made in the last few hours, and the deck manager seems to be working as intended.

Suggestions from my end to consider:

1. Sorting by win percentage needs optimization. One approach could be to use a pre-computed data structure containing a map from the deck to its wins, losses, ties/draws and win percentage. At the end of each game, the four values for the played deck are updated. Maintaining an inverted index from the Win Percentage to the Deck should help a lot when sorting by Win Percentage.
2. If the sort dropdown can be decoupled from the rest of the functionality within the Deck Manager, so that it remains responsive even if the Deck Manager is unresponsive, then that would prevent this specific issue and other similar ones

Note: These are just suggestions. Request you to consider them and hopefully add them to the backlog and prioritize appropriately

Thanks again for the prompt response that motivated me to monitor the app and report the findings

[fmoraes74]

I am sure not sure when I will have time to work on this but I can see how the code is very inefficient. It was like this when I took over the project, so I never looked at improving that part. If you don't mind sharing your deck database, that would be helpful for when I get the time to work on it.

[prasanna2991]

@fmoraes74 Sorry for the late response. I checked this thread just now.

How do I share my deck database? Is there a specific file I need to upload from my Macbook Air M1 ?

[prasanna2991]

@fmoraes74 Any thoughts please?

@fmoraes74 Sorry for the late response. I checked this thread just now.

How do I share my deck database? Is there a specific file I need to upload from my Macbook Air M1 ?

[fmoraes74]

Sorry, had a busy week at work. You can use copy ~/Library/Application\ Support/HSTracker/hstracker.realm

[prasanna2991]

@fmoraes74 hstracker.realm is a 475mb file. I've compressed it with maximum compression to a tgz file. The default Archive Utility can decompress it

SHA256 checksum of hstracker.realm is: de19a554dced92ab43d3a94d83b9e7ab4dacc032a60d0533431c762aaf18caae

hstracker.realm.tgz

[prasanna2991]

@fmoraes74 I hope you're doing well. Request your acknowledgement of my deck database, please.