Skip to content

Commit 21fdcda

Browse files
authored
Restore TAG_CHANGES in BOARD_VISUAL_STATE=2 TRIGGER blocks (#16)
There's some logic in the filter to strip out tag changes that share a TRIGGER block with a tag change that sets BOARD_VISUAL_STATE to 2. We believe that for some time now, BOARD_VISUAL_STATEs 1 or 2 are related to shop manipulation code and not part of what we want to capture in combat. However! In a recent BGS log, there are tag changes that seem to represent enchantments (i.e., ATK and HEALTH buffs) being applied to entities in a BOARD_VISUAL_STATE=2 block; whereas in older BGS logs, that happens in a separate block. This change removes the logic that was stripping all BOARD_VISUAL_STATE=2 block tag changes.
1 parent ffc1ce7 commit 21fdcda

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

hslog/filter.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@ class BattlegroundsLogFilter(Iterable):
100100
- All options messages (from DebugPrintOptions) are discarded
101101
- Blacklisted and unknown tags for FULL_ENTITY and SHOW_ENTITY messages are discarded
102102
- TAG_CHANGES containing blacklisted and unknown tags are discarded
103-
- All TAG_CHANGES that are part of a TRIGGER block that include a BOARD_VISUAL_STATE=2
104-
tag change are discarded
105103
- All TAG_CHANGES that precede a BOARD_VISUAL_STATE=1 tag change in a TRIGGER block are
106104
discarded
107105
"""
@@ -392,9 +390,6 @@ def _handle_tag_change(self, msg: str, line: str):
392390
buf.should_skip = True
393391
self._current_buffer.buffer[i] = buf
394392

395-
if value == "2":
396-
setattr(self._current_buffer, "skip_tag_changes", True)
397-
398393
return
399394

400395
# If we're already buffering a DEATHS block, then changing the PLAYER_TECH_LEVEL

0 commit comments

Comments
 (0)