Skip to content

Conversation

akshith-gunasheelan
Copy link
Collaborator

@akshith-gunasheelan akshith-gunasheelan commented May 21, 2025

Description

This PR addresses an issue in the Terraform provider where firmware URIs referencing external repositories could not be read correctly. The problem stemmed from improper parsing of the mirrorList field, which caused all associated fields to be returned as null. As a result, even though the configuration structure was valid, the provider failed to reflect the actual state accurately.

Fix:
We are removing the use of the mirrorList attribute, as the required URIs are already accessible through another field. Since mirrorList is redundant in this context and causes issues with state reading, its removal simplifies the logic and ensures accurate state reflection in Terraform.

Issues Resolved

HewlettPackard/terraform-provider-oneview#570

Check List

  • New functionality includes testing.
    • All tests pass for go 1.11 + gofmt checks.
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

Copy link
Collaborator

@AvijitOS AvijitOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some note in documentation that mirrorlist has been removed

@akshith-gunasheelan akshith-gunasheelan merged commit 13999d4 into master May 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants