Skip to content

fix: remove links refering to moved blocks #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove links refering to moved blocks #952

wants to merge 1 commit into from

Conversation

IkbelTalebHssan
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan commented Apr 23, 2025 •
edited by coderabbitai bot
Loading

Motivation

This PR fixes the removal of links remaining after moving one or multiple blocks.

Fixes #951

Screencast.from.04-23-2025.12.31.49.PM.webm

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of linked blocks when updating block connections outside a given category, ensuring more accurate retention and removal of links.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 23, 2025 •
edited
Loading

Walkthrough

The code modifies the internal logic of the prepareBlocksOutOfCategoryUpdateScope method within the BlockRepository class. The update refines how nextBlocks references are filtered and updated for blocks outside a specified category scope when certain blocks are moved. The new implementation more precisely determines which nextBlocks references to remove, ensuring only those pointing to moved blocks without reciprocal links are affected. The handling for attachedBlock remains unchanged.

Changes

File(s) Change Summary
api/src/chat/repositories/block.repository.ts Refined logic in prepareBlocksOutOfCategoryUpdateScope to selectively remove nextBlocks references to moved blocks, improving accuracy of link updates when blocks are moved. No public API or signature changes.

Sequence Diagram(s)

sequenceDiagram
    participant BlockRepository
    participant Database

    BlockRepository->>Database: Fetch moved blocks and their nextBlocks
    BlockRepository->>Database: Fetch external blocks referencing moved blocks
    loop For each external block
        BlockRepository->>BlockRepository: Filter nextBlocks (retain if not referencing moved or if reciprocal)
        BlockRepository->>BlockRepository: Clear attachedBlock if referencing moved block
        BlockRepository->>Database: Update block if changes detected
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Ensure nextBlocks links referencing moved blocks are properly removed (#951) ✅

Poem

A hop and a skip, the blocks rearrange,
With careful new logic, their links now change.
NextBlocks are checked, with a reciprocal glance,
Only the right ones get trimmed in this dance.
AttachedBlock stays wary, as always before—
The rabbit ensures, loose ends are no more!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b2bfd0 and ceb04f3.

📒 Files selected for processing (1)
  • api/src/chat/repositories/block.repository.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: API-Tests
  • GitHub Check: Frontend Tests
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
api/src/chat/repositories/block.repository.ts (3)

208-215: Good addition: Building a set of reciprocal link targets

The new code correctly fetches all moved blocks and builds a set of their link targets. This is a crucial part of the fix that enables preservation of reciprocal links between blocks.

222-227: Fix implemented correctly: Preserving mutual block references

This implementation correctly solves the issue where links remain after moving blocks. The new logic:

  1. Keeps links that don't point to moved blocks (as before)
  2. Preserves links to moved blocks that have a reciprocal relationship (bi-directional references)

The condition movedBlockLinkTargets.has(block.id) ensures that if a moved block points back to the current block, the connection is maintained.

229-231: Performance optimization: Avoid unnecessary database updates

Good improvement! By only triggering an update when the nextBlocks array has actually changed, you're reducing unnecessary database operations.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassinedorbozgithub yassinedorbozgithub yassinedorbozgithub approved these changes

@marrouchi marrouchi Awaiting requested review from marrouchi

@medchedli medchedli Awaiting requested review from medchedli

@abdou6666 abdou6666 Awaiting requested review from abdou6666

@MohamedAliBouhaouala MohamedAliBouhaouala Awaiting requested review from MohamedAliBouhaouala

At least 2 approving reviews are required to merge this pull request.

Assignees

@IkbelTalebHssan IkbelTalebHssan

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - NextBlocks links referencing to moved blocks are not removed
3 participants
@IkbelTalebHssan @yassinedorbozgithub @medchedli