Update TS and fix breaking changes in functions

Author: HugoGresse

functions/package-lock.json

@@ -36,7 +36,6 @@
         "firebase-tools": "13.6.0",
         "form-data": "^3.0.1",
         "lodash": "^4.17.21",
-        "node-fetch": "^2.6.1",
         "ts-custom-error": "^3.3.1"
     },
     "devDependencies": {
@@ -47,7 +46,7 @@
         "eslint-plugin-import": "^2.25.4",
         "firestore-vitest": "^0.20.2",
         "jest-expect-message": "^1.0.2",
-        "typescript": "^4.9.5",
+        "typescript": "^5.9.3",
         "vitest": "^4.0.4"
     },
     "private": true

functions/package.json

@@ -1,5 +1,4 @@
 import * as functions from 'firebase-functions'
-import fetch from 'node-fetch'
 import { isEmpty } from 'lodash'
 import { getOpsGenieEnv } from '../helpers/env'
 

functions/src/callable/alert.ts

@@ -1,6 +1,4 @@
 import { isEmpty } from 'lodash'
-import FormData from 'form-data'
-import fetch, { Response } from 'node-fetch'
 import { MailgunEnv } from '../types/MailgunEnv'
 
 export interface EmailData {

functions/src/email/send.ts

@@ -1,5 +1,5 @@
 import { onRequest } from 'firebase-functions/v2/https'
-import { createApiServer } from '../api/api'
+import { createFastifyAPI } from '../api/api'
 
 // Export the API as a Firebase HTTP function
 export const api = onRequest(
@@ -13,7 +13,7 @@ export const api = onRequest(
     async (request, response) => {
         try {
             // Create and start the Fastify server
-            const server = await createApiServer()
+            const server = await createFastifyAPI()
 
             // Use Fastify's built-in adapter for Firebase Functions
             await server.ready()

functions/src/http/apiFunction.ts

@@ -1,6 +1,5 @@
 import * as functions from 'firebase-functions'
 import { getAppEnv, getMailgunEnv } from '../helpers/env'
-import fetch, { Response } from 'node-fetch'
 import send from '../email/send'
 
 export const sendContactEmail = functions.https.onRequest(async (req, res) => {
@@ -58,11 +57,11 @@ const isRecaptchaV3Valid = async (recaptchaV3Value: string) => {
     return fetch(
         `https://www.google.com/recaptcha/api/siteverify?secret=${appEnv.recaptchaV3Secret}&response=${recaptchaV3Value}`
     )
-        .then((response) => response.json())
-        .then((response) => {
+        .then((response: Response) => response.json())
+        .then((response: { success: boolean; score: number }) => {
             return response.success && response.score > 0.5
         })
-        .catch((error) => {
+        .catch((error: Error) => {
             console.error(error)
             return false
         })

functions/src/http/sendContactEmail.ts

@@ -2,7 +2,6 @@ import * as functions from 'firebase-functions'
 import admin from 'firebase-admin'
 import send from '../../email/send'
 import { isEmpty } from 'lodash'
-import { Response } from 'node-fetch'
 import { getAppEnv, getMailgunEnv } from '../../helpers/env'
 import { generateInviteEmail } from './generateInviteEmail'
 import { applyInvites } from './applyInvites'