Fi feature detect misalignment #205
Conversation
.github/workflows/buildPlugin.yml
Outdated
There was a problem hiding this comment.
Why do you modify the buildPluing.yml? Is this on purpose?
There was a problem hiding this comment.
Yes, this is due to some changes in scipion_testrunner installation and execution. In theory, this might be solved once #201 is merged. Conflicts might appear when merging with devel though.
Until that PR is approved all PR in this repo are blocked since the test will not pass.
| @@ -2,3 +2,5 @@ scipion-em-xmipp | |||
| scipion-em-tomo | |||
| scipion-em >= 3.0.8 | |||
| scipion-em-xmippBase | |||
| pandas <= 1.3.5 | |||
There was a problem hiding this comment.
This dependence is on Scipion, I guess @oierlauzi
There was a problem hiding this comment.
No, there is no dependency on pandas in any of the required packages by this plugin. That's why this is added here.
xmipptomo/protocols.conf
Outdated
| {"tag": "protocol", "value": "XmippProtSplitTiltSeries", "text": "default"} | ||
| ]}, | ||
| {"tag": "protocol_group", "text": "CTF", "openItem": "False", "children": [ | ||
| {"tag": "protocol", "value": "XmippProtRotateAstigmatism", "text": "default"} |
|
|
||
| class XmippProtDetectLandmarkTS(EMProtocol, ProtTomoBase): | ||
| """ | ||
| Scipion protocol for xmipp_tomo_detect_landmarks. Detect landmarks in a tilt series. |
There was a problem hiding this comment.
add more help to explain what the protocol does, including key words to simplify the search of the protocol in the search box of scipion. For instance, including the word gold bead or fiducial
|
|
This PR includes LaFedeTesis vol. 2 which means:
This plugin depends on: I2PC/xmipp#988