Skip to content

Commit 237fa4b

Browse files
authored
TAZ and test framework fixes (#564)
* Fixes to TAZ updates * Updating preview build test case Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
1 parent 3fb11a0 commit 237fa4b

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

test/applications/MortgageApplication/test.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ impactBuild_changedFiles = bms/epsmort.bms,cobol/epsmlist.cbl,copybook/epsmtout.
6767
impactBuild_datasetsToCleanUp = BMS,COBOL,LINK
6868
#
6969
# Use file properties to associate expected files built to changed files
70-
impactBuild_expectedFilesBuilt = epsmort.bms,epscmort.cbl :: bms/epsmort.bms
70+
impactBuild_expectedFilesBuilt = epsmort.bms,epscmort.cbl,epsnbrvl.cbl :: bms/epsmort.bms
7171
impactBuild_expectedFilesBuilt = epsmlist.cbl,epsmlist.lnk :: cobol/epsmlist.cbl
72-
impactBuild_expectedFilesBuilt = epsmlist.cbl,epscsmrt.cbl,epscmort.cbl,epsmlist.lnk :: copybook/epsmtout.cpy
72+
impactBuild_expectedFilesBuilt = epsmlist.cbl,epscsmrt.cbl,epscmort.cbl,epsmlist.lnk,epsnbrvl.cbl :: copybook/epsmtout.cpy
7373
impactBuild_expectedFilesBuilt = epsmlist.lnk :: link/epsmlist.lnk
7474

7575

@@ -124,7 +124,7 @@ impactBuild_preview_changedFiles = copybook/epsmtout.cpy
124124
impactBuild_preview_datasetsToCleanUp = BMS,COBOL,LINK
125125
#
126126
# Use file properties to associate expected files built to changed files
127-
impactBuild_preview_expectedFilesBuilt = epsmlist.cbl,epscsmrt.cbl,epscmort.cbl,epsmlist.lnk :: copybook/epsmtout.cpy
127+
impactBuild_preview_expectedFilesBuilt = epsmlist.cbl,epscsmrt.cbl,epscmort.cbl,epsmlist.lnk,epsnbrvl.cbl :: copybook/epsmtout.cpy
128128

129129

130130
#############################

test/testScripts/impactBuild_preview.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,14 @@ def validateImpactBuild(String changedFile, PropertyMappings filesBuiltMappings,
111111

112112
try{
113113
// Validate clean build
114-
assert outputStream.contains("Build State : CLEAN") : "*! IMPACT BUILD FAILED FOR $changedFile\nOUTPUT STREAM:\n$outputStream\n"
114+
assert outputStream.contains("Build State : CLEAN") : "*! IMPACT BUILD WITH PREVIEW FOR $changedFile\nOUTPUT STREAM:\n$outputStream\n"
115115

116116
// Validate expected number of files built
117117
def numImpactFiles = expectedFilesBuiltList.size()
118-
assert outputStream.contains("Total files processed : ${numImpactFiles}") : "*! IMPACT BUILD FOR $changedFile TOTAL FILES PROCESSED ARE NOT EQUAL TO ${numImpactFiles}\nOUTPUT STREAM:\n$outputStream\n"
118+
assert outputStream.contains("Total files processed : ${numImpactFiles}") : "*! IMPACT BUILD WITH PREVIEW FOR $changedFile TOTAL FILES PROCESSED ARE NOT EQUAL TO ${numImpactFiles}\nOUTPUT STREAM:\n$outputStream\n"
119119

120120
// Validate expected built files in output stream
121-
assert expectedFilesBuiltList.count{ i-> outputStream.contains(i) } == expectedFilesBuiltList.size() : "*! IMPACT BUILD FOR $changedFile DOES NOT CONTAIN THE LIST OF BUILT FILES EXPECTED ${expectedFilesBuiltList}\nOUTPUT STREAM:\n$outputStream\n"
121+
assert expectedFilesBuiltList.count{ i-> outputStream.contains(i) } == expectedFilesBuiltList.size() : "*! IMPACT BUILD WITH PREVIEW FOR $changedFile DOES NOT CONTAIN THE LIST OF BUILT FILES EXPECTED ${expectedFilesBuiltList}\nOUTPUT STREAM:\n$outputStream\n"
122122

123123
println "**"
124124
println "** IMPACT BUILD WITH PREVIEW TEST : PASSED FOR $changedFile **"

utilities/ImpactUtilities.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ def createImpactBuildList() {
6464
// if the changed file has a build script then add to build list
6565
if (ScriptMappings.getScriptName(changedFile)) {
6666
// skip adding generated test cases, when the testing is disabled
67-
if (buildUtils.isGeneratedzUnitTestCaseProgram(changedFile) && !(props.runzTests && props.runzTests.toBoolean())) {
68-
if (props.verbose) println "** Identified $changedFile as a generated zunit test case program. Processing zUnit tests is not enabled for this build. Skip building this program."
67+
if (buildUtils.isGeneratedTazTestCaseProgram(changedFile) && !(props.runzTests && props.runzTests.toBoolean())) {
68+
if (props.verbose) println "** Identified $changedFile as a generated TAZ unit test case program. Processing TAZ unit tests is not enabled for this build. Skip building this program."
6969
} else {
7070
buildSet.add(changedFile)
7171
if (props.verbose) println "** Found build script mapping for $changedFile. Adding to build list"
@@ -802,7 +802,7 @@ def boolean shouldCalculateImpacts(String changedFile){
802802
if (onskipImpactCalculationList) return false
803803

804804
// return false if the changed file is a generated test case program but testing is disabled
805-
if (buildUtils.isGeneratedzUnitTestCaseProgram(changedFile) && !(props.runzTests && props.runzTests.toBoolean())) {
805+
if (buildUtils.isGeneratedTazTestCaseProgram(changedFile) && !(props.runzTests && props.runzTests.toBoolean())) {
806806
return false
807807
}
808808

0 commit comments

Comments
 (0)