Skip to content

Conversation

AnjaliAbraham
Copy link
Member

Enhance the Jenkins pipeline template to include the TAZ EDT test results.

Copy link
Member

@dennis-behm dennis-behm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnjaliAbraham - I have a few comments on the PR. Please have a look below. Many thanks for working on this enhancement!

Copy link
Member

@dennis-behm dennis-behm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments @AnjaliAbraham


dir ("${BuildOutputDir}") {
BuildFile = findFiles(glob: "buildList.txt")
TazReports = findFiles(glob: TazLogs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. For better readability I would prefer to see the publishing after the build status is reported to the build.
  2. Changing my mind, we should introduce a variable tazReportsDoPublish to let the user turn on the publishing via this flag. Please also add the variable to the prints of the build variable summary.

def BuildFile = "" // Will contain the contents of the DBB buildFile.txt.
def BuildHasFiles = true // DBB buildFile.txt indicates changed files.

// TAZ Unit Test results to JUnit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should rather go into the README where we talk about install + setup.

Please make sure to document this new capability in the table of all pipeline implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants