-
Notifications
You must be signed in to change notification settings - Fork 140
TAZ EDT results conversion for Jenkins template #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TAZ EDT results conversion for Jenkins template #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnjaliAbraham - I have a few comments on the PR. Please have a look below. Many thanks for working on this enhancement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments @AnjaliAbraham
|
||
dir ("${BuildOutputDir}") { | ||
BuildFile = findFiles(glob: "buildList.txt") | ||
TazReports = findFiles(glob: TazLogs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For better readability I would prefer to see the publishing after the build status is reported to the build.
- Changing my mind, we should introduce a variable
tazReportsDoPublish
to let the user turn on the publishing via this flag. Please also add the variable to the prints of the build variable summary.
def BuildFile = "" // Will contain the contents of the DBB buildFile.txt. | ||
def BuildHasFiles = true // DBB buildFile.txt indicates changed files. | ||
|
||
// TAZ Unit Test results to JUnit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should rather go into the README where we talk about install + setup.
Please make sure to document this new capability in the table of all pipeline implementations.
Enhance the Jenkins pipeline template to include the TAZ EDT test results.