update yuvRgbConvCoeffs slightly#653
Open
for13to1 wants to merge 1 commit intoIENT:developfrom
Open
Conversation
|
Those are just off-by-one. Unless you give a triplet where it is a clear improvement... |
Contributor
Author
|
I really think https://github.com/sekrit-twc/zimg should be adopted instead and be done with it. No one here has enough expertise to reverse engineer this code. And I worked on some ffmpeg codebase related to color. @haasn may know this but I doubt he will want to help some obscure project. Though we all use this project in ffmpeg for verification... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor modifications here can bring the conversion result closer to the theoretical value, as mentioned in #584