fix(assessmentUtils): update the assessments in a temporary models when the source is read-only #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexanderpann
commented
Nov 27, 2025
alexanderpann
commented
- fixes AssessmentAnalyzer tries to modify read only models #1526
…en the source is readonly
Member
|
Is it enought to just copy the root node to the temproral model? Don't we need to add the all dep. to the model as well? |
Member
|
Looks like the assessment API changed in the meantime: This call is no loger valid. 
I'll update the call. |
arimer
approved these changes
Dec 8, 2025
Member
arimer
left a comment
arimer
left a comment
There was a problem hiding this comment.
Fixed oudated API and flipped the consequences in case MPSProject is available or not.
Thanks for the fix ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.