DREF Imminent v2 Final Report #1942
Conversation
🦋 Changeset detectedLatest commit: 3ee9979 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| headingLevel={3} | ||
| childrenContainerClassName={styles.proposedActions} | ||
| > | ||
| <div className={styles.actionTitleLabel} /> |
There was a problem hiding this comment.
Its empty. It is needed?
| {strings.priorityActionsBudget} | ||
| </div> | ||
| <div className={styles.actionTitleLabel}> | ||
| Expenditure |
| </div> | ||
| {proposedAction.actions.map((action) => ( | ||
| <Fragment key={action.id}> | ||
| {action.activities.map((activity, i) => ( |
There was a problem hiding this comment.
it would easier to read if we write index instead of i.
| (value: Maybe<number>) => ( | ||
| // FIXME: use translations | ||
| isDefined(value) && value !== SUB_TOTAL | ||
| ? 'The sub-total of the budgets should be exactly CHF 75000' |
There was a problem hiding this comment.
Use translation. do not forget to remove FIXME.
| /** @knipignore */ | ||
| // eslint-disable-next-line import/prefer-default-export | ||
| export function Component() { | ||
| const { finalReportId } = useParams<{ finalReportId: string }>(); | ||
| const [previewReady, setPreviewReady] = useState(false); | ||
| const strings = useTranslation(i18n); | ||
| const primarySectorOptions = usePrimarySector(); | ||
|
|
||
| const { | ||
| // pending: fetchingDref, |
There was a problem hiding this comment.
remove commented line it not needed
|
|
||
| const sortedPlannedInterventions = useMemo( | ||
| () => filteredPlannedIntervention?.sort( | ||
|
|
|
|
||
| const sortedIdentifiedNeedsAndGaps = useMemo( | ||
| () => filteredIdentifiedNeedsAndGaps?.sort( | ||
|
|
| <img | ||
| className={styles.icon} | ||
| src={identifiedNeed.image_url} | ||
| alt="" |
| <img | ||
| className={styles.icon} | ||
| src={plannedIntervention.image_url} | ||
| alt="" |
| /* | ||
| if ((response.photos_file?.length ?? 0) > 0) { | ||
| response.photos_file?.forEach((img) => { | ||
| if (isDefined(img.file)) { | ||
| newMap[img.id] = img.file; | ||
| } | ||
| }); | ||
| } | ||
| */ |
There was a problem hiding this comment.
Remove commented or add Note
There was a problem hiding this comment.
@barshathakuri @AdityaKhatri For future references, this should have been done using fixup commit! It wouldn't be possible to revert back to the moved migration!
* refactor(dref-export-modal): update pga state management logic
- use total_operation_timeframe_imminent in both form and export for imminent final report
AdityaKhatri
force-pushed
the
project/dref-imminent-v2-final-report
branch
from
1d0bccd to
3ee9979
Compare
Summary
Update final report form for dref imminent type
Addresses
Depends On
Changes
This PR Ensures:
console.logstatements meant for debugging