Urb-3342 #380
Open
Urb-3342 #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is still in progress This reverts commit 49a305e.
…for SPW cyberattack
duchenean
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Hello @WBoudabous
Ça m'a l'air OK. Peut-être demander à quelqu'un d'autre un second avis.
| profile="Products.urban:default" | ||
| /> | ||
| <gs:upgradeStep | ||
| title="Add new vocabulary Municaipal Directive" |
mpeeters
requested changes
Aug 5, 2025
| msgid "zip_folder_title" | ||
| msgstr "Zone d'initiative privilégiée" | ||
|
|
||
| msgid "chapter_1" |
There was a problem hiding this comment.
Please run the script to generate po files, which avoids duplicates and indicates the file and line number.
There was a problem hiding this comment.
Please run black, multiple issues in this
| from zope.component import getUtility | ||
|
|
||
| import logging | ||
| from zope.i18n import translate |
There was a problem hiding this comment.
please run isort to ensure that imports are ordered correctly
|
|
||
| municipal_directive_vocabulary_config = [ | ||
|
|
||
| { |
There was a problem hiding this comment.
Wrong indent, please run black.
|
In addition to my previous comments, please update your branch to resolve conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout du vocabulaire "directive communal" et d’un nouveau champ associé
Cette pull request introduit les modifications suivantes :