-
Notifications
You must be signed in to change notification settings - Fork 35
out-of-the-box support for Astaria's hashing and colorisation of the mapper #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added astaria to script - todo: convert room id to allow for hash
Add support for games that operate on hashes (IRE-Mudlet-Mapping#186)
Added support for Astaria's game env and colorisation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A couple of comments below -
@@ -7094,7 +7132,7 @@ function mmp.gotoFeature(partialFeatureName, dashtype) | |||
return | |||
end | |||
raiseEvent("mmp clear externals") | |||
mmp.gotoRoom(closestFeature, dashtype, "room") | |||
mmp.gotoRoom(closestFeature, dashtype, "area") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this change do?
@@ -10379,6 +10417,7 @@ end | |||
if gmcp.Room.Info.num then | |||
centerview(gmcp.Room.Info.num) | |||
elseif gmcp.Room.Info.roomhash then | |||
print(tostring(mmp.roomidFromHash(gmcp.Room.Info.roomhash))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug?
@araskal is this good to go? |
After a fair bit of trial and error this is all working for Astaria - though I am not sure whether there's any issues with other MUD's, I tried to limit any changes.