Skip to content

Commit 4f379e1

Browse files
tresfIanCaio
authored andcommitted
Fix DMG titles > 27 chars (LMMS#5741)
Workaround upstream bug LinusU/node-appdmg#48
1 parent c169d3d commit 4f379e1

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

cmake/apple/CMakeLists.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ SET(MACOSX_BUNDLE_MIMETYPE "application/x-lmms-project")
99
SET(MACOSX_BUNDLE_MIMETYPE_ICON "project.icns")
1010
SET(MACOSX_BUNDLE_MIMETYPE_ID "io.lmms")
1111
SET(MACOSX_BUNDLE_PROJECT_URL "${PROJECT_URL}")
12+
SET(MACOSX_BUNDLE_DMG_TITLE "${MACOSX_BUNDLE_BUNDLE_NAME} ${MACOSX_BUNDLE_LONG_VERSION_STRING}")
13+
14+
# FIXME: appdmg won't allow volume names > 27 char
15+
# See also https://github.com/LinusU/node-appdmg/issues/48
16+
STRING(SUBSTRING "${MACOSX_BUNDLE_DMG_TITLE}" 0 27 MACOSX_BUNDLE_DMG_TITLE)
1217

1318
CONFIGURE_FILE("lmms.plist.in" "${CMAKE_BINARY_DIR}/Info.plist")
1419
CONFIGURE_FILE("install_apple.sh.in" "${CMAKE_BINARY_DIR}/install_apple.sh" @ONLY)

cmake/apple/package_apple.json.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"title": "@MACOSX_BUNDLE_BUNDLE_NAME@ @MACOSX_BUNDLE_LONG_VERSION_STRING@",
2+
"title": "@MACOSX_BUNDLE_DMG_TITLE@",
33
"background": "@CMAKE_SOURCE_DIR@/cmake/apple/dmg_branding.png",
44
"icon-size": 128,
55
"contents": [

0 commit comments

Comments
 (0)