Fix for non reference of char pointer #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On arch linux, this project did not compile due to
CC libpal_la-palDfltin.lo
palDfltin.c: In function 'palDfltin':
palDfltin.c:185:3: error: implicit declaration of function 'strlcpy'; did you mean 'strncpy'? [-Wimplicit-function-declaration]
185 | strlcpy( tempbuf, &(string[*nstrt-1]), sizeof(tempbuf) );
| ^~~~~~~
| strncpy
After some debugging, the issue seems that HAVE_BSD_STRING_H was never set and thus the include never happens.
Fix configure.ac
After looking at this compiler warning for some time:
palIntin.c: In function 'palIntin':
palIntin.c:132:17: warning: comparison between pointer and zero character constant [-Wpointer-compare]
132 | while ( ctemp != '\0' ) {
| ^~
palIntin.c:132:11: note: did you mean to dereference the pointer?
132 | while ( ctemp != '\0' ) {
| ^
I think what people actually wanted to do is looking for the terminator of the string to not end up in a infinite loop.
However, ctemp is char * and thus needs to be de-referenced?
That code is 10 years old though so it is unclear to me how it could be wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
after looking at
palIntin.c: In function 'palIntin':
palIntin.c:132:17: warning: comparison between pointer and zero character constant [-Wpointer-compare]
132 | while ( ctemp != '\0' ) {
| ^~
palIntin.c:132:11: note: did you mean to dereference the pointer?
132 | while ( ctemp != '\0' ) {
| ^
I think this is wrong and should be while (*ctemp) to actually look for the end of the string.