Fix: Remove false positive due to not checking object_filter changes

Author: raviks789

application/controllers/EventRuleController.php

@@ -48,7 +48,7 @@ public function indexAction(): void
         $ruleId = $this->params->getRequired('id');
 
         $eventRuleConfigValues = $this->fromDb((int) $ruleId);
-        $filter = &$eventRuleConfigValues['object_filter']; // Assignment by reference to is used as search editor is a
+        $filter = $eventRuleConfigValues['object_filter'];  // Assignment by reference to is used as search editor is a
                                                             // different form and the config must have the updated
                                                             // object_filter as soon as the search editor is closed
 
@@ -65,7 +65,8 @@ public function indexAction(): void
             Url::fromPath(
                 'notifications/event-rule/search-editor',
                 ['id' => $ruleId, 'object_filter' => $filter]
-            )
+            ),
+            $filter
         ))
             ->populate($eventRuleConfigValues)
             ->on(Form::ON_SUCCESS, function (EventRuleConfigForm $form) use ($ruleId, $eventRuleConfigValues) {

application/forms/EventRuleConfigForm.php

@@ -50,16 +50,20 @@ class EventRuleConfigForm extends Form
     /** @var bool Whether the config has an escalation with no condition */
     protected $hasZeroConditionEscalation = false;
 
+    /** @var ?string */
+    protected $objectFilter;
+
     /**
      * Create a new EventRuleConfigForm
      *
      * @param array<string, mixed> $config
      * @param Url $searchEditorUrl
      */
-    public function __construct(array $config, Url $searchEditorUrl)
+    public function __construct(array $config, Url $searchEditorUrl, ?string $objectFilter)
     {
         $this->config = $config;
         $this->searchEditorUrl = $searchEditorUrl;
+        $this->objectFilter = $objectFilter;
     }
 
     public function hasBeenSubmitted(): bool
@@ -179,7 +183,7 @@ protected function assemble(): void
             $this->getElement('zero-condition-escalation')->setValue($defaultEscalationPrefix);
         }
 
-        $configFilter = new EventRuleConfigFilter($this->searchEditorUrl, $this->config['object_filter']);
+        $configFilter = new EventRuleConfigFilter($this->searchEditorUrl, $this->objectFilter);
         $this->registerElement($configFilter);
 
         $addEscalationButton = new SubmitButtonElement(
@@ -463,7 +467,8 @@ public function updateRule(int $id, array $config): int
     {
         $db = Database::get();
         $db->beginTransaction();
-        $db->update('rule', ['object_filter' => $config['object_filter'] ?? null], ['id = ?' => $id]);
+
+        $db->update('rule', ['object_filter' => $this->objectFilter], ['id = ?' => $id]);
 
         if (! isset($config['rule_escalation'])) {
             $db->commitTransaction();