IncidentDetail: Add method return type and use HtmlElement

sukhwinder33445 · sukhwinder33445 · commit 43d81c6b30b3 · 2025-02-24T11:36:02.000+01:00
diff --git a/library/Notifications/Widget/Detail/IncidentDetail.php b/library/Notifications/Widget/Detail/IncidentDetail.php
@@ -92,7 +92,7 @@ protected function createSource()
         ];
     }
 
-    protected function createObjectTag()
+    protected function createObjectTag(): array
     {
         $tags = [];
         foreach ($this->incident->object->object_extra_tag as $extraTag) {
@@ -104,7 +104,7 @@ protected function createObjectTag()
         }
 
         return [
-            Html::tag('h2', t('Object Tags')),
+            new HtmlElement('h2', null, new Text(t('Object Tags'))),
             (new Table())
                 ->addHtml(...$tags)
                 ->addAttributes(['class' => 'object-tags-table'])

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ protected function createSource()`
`92`	`92`	`];`
`93`	`93`	`}`
`94`	`94`
`95`		`- protected function createObjectTag()`
	`95`	`+ protected function createObjectTag(): array`
`96`	`96`	`{`
`97`	`97`	`$tags = [];`
`98`	`98`	`foreach ($this->incident->object->object_extra_tag as $extraTag) {`
`@@ -104,7 +104,7 @@ protected function createObjectTag()`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`return [`
`107`		`- Html::tag('h2', t('Object Tags')),`
	`107`	`+ new HtmlElement('h2', null, new Text(t('Object Tags'))),`
`108`	`108`	`(new Table())`
`109`	`109`	`->addHtml(...$tags)`
`110`	`110`	`->addAttributes(['class' => 'object-tags-table'])`