RotationConfigForm: Don't increase priority when editing a rotation

The priority of existing rotations should only be increased when creating a new rotation

Author: sukhwinder33445

application/forms/RotationConfigForm.php

@@ -280,16 +280,19 @@ public function loadRotation(int $rotationId): self
     /**
      * Insert a new rotation in the database
      *
-     * @param int $priority The priority of the rotation
+     * @param ?int $priority The priority of the rotation to add.
+     *
+     * If no priority is specified, the priority of all existing schedule rotations is increased by 1, and the
+     * new rotation is added with the lowest priority (zero).
      *
      * @return Generator<int, DateTime> The first handoff of the rotation, as value
      */
-    private function createRotation(int $priority): Generator
+    private function createRotation(int $priority = null): Generator
     {
         $data = $this->getValues();
         $data['options'] = Json::encode($data['options']);
         $data['schedule_id'] = $this->scheduleId;
-        $data['priority'] = $priority;
+        $data['priority'] = $priority ?? 0;
 
         $members = array_map(function ($member) {
             return explode(':', $member, 2);
@@ -312,17 +315,19 @@ private function createRotation(int $priority): Generator
 
         $changedAt = (int) (new DateTime())->format("Uv");
 
-        $rotationsToMove = Rotation::on($this->db)
-            ->columns('id')
-            ->filter(Filter::equal('schedule_id', $this->scheduleId))
-            ->orderBy('priority', SORT_DESC);
-
-        foreach ($rotationsToMove as $rotation) {
-            $this->db->update(
-                'rotation',
-                ['priority' => new Expression('priority + 1'), 'changed_at' => $changedAt],
-                ['id = ?' => $rotation->id]
-            );
+        if ($priority === null) {
+            $rotationsToMove = Rotation::on($this->db)
+                ->columns('id')
+                ->filter(Filter::equal('schedule_id', $this->scheduleId))
+                ->orderBy('priority', SORT_DESC);
+
+            foreach ($rotationsToMove as $rotation) {
+                $this->db->update(
+                    'rotation',
+                    ['priority' => new Expression('priority + 1'), 'changed_at' => $changedAt],
+                    ['id = ?' => $rotation->id]
+                );
+            }
         }
 
         $data['changed_at'] = $changedAt;
@@ -395,7 +400,7 @@ public function addRotation(): void
             $transactionStarted = $this->db->beginTransaction();
         }
 
-        $this->createRotation(0)->send(true);
+        $this->createRotation()->send(true);
 
         if ($transactionStarted) {
             $this->db->commitTransaction();